Skip to content

refactor: upgrade parse from 3.4.2 to 3.4.3 #8113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

refactor: upgrade parse from 3.4.2 to 3.4.3 #8113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8957734
fix: upgrade parse from 3.4.2 to 3.4.3
snyk-bot Jul 24, 2022
e63121f
Update FilesRouter.js
dblythy Jul 26, 2022
1092f2e
Merge branch 'alpha' into update-parse
dblythy Jul 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 14 additions & 14 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
"mime": "3.0.0",
"mongodb": "4.6.0",
"mustache": "4.2.0",
"parse": "3.4.2",
"parse": "3.4.3",
"pg-monitor": "1.4.1",
"pg-promise": "10.11.1",
"pluralize": "8.0.0",
Expand Down
17 changes: 8 additions & 9 deletions src/Routers/FilesRouter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,15 +136,14 @@ export class FilesRouter {
next(error);
return;
}

const base64 = req.body.toString('base64');
const file = new Parse.File(filename, { base64 }, contentType);
const { metadata = {}, tags = {} } = req.fileData || {};
file.setTags(tags);
file.setMetadata(metadata);
const fileSize = Buffer.byteLength(req.body);
const fileObject = { file, fileSize };
try {
const {data} = req.body.toJSON();
const file = new Parse.File(filename, data, contentType);
const { metadata = {}, tags = {} } = req.fileData || {};
file.setTags(tags);
file.setMetadata(metadata);
const fileSize = Buffer.byteLength(req.body);
const fileObject = { file, fileSize };
// run beforeSaveFile trigger
const triggerResult = await triggers.maybeRunFileTrigger(
triggers.Types.beforeSave,
Expand Down Expand Up @@ -208,7 +207,7 @@ export class FilesRouter {
logger.error('Error creating a file: ', e);
const error = triggers.resolveError(e, {
code: Parse.Error.FILE_SAVE_ERROR,
message: `Could not store file: ${fileObject.file._name}.`,
message: `Could not store file: ${filename}.`,
});
next(error);
}
Expand Down