Skip to content

Additional explication for expireInactiveSessions in ParseServerOptions #7552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 10, 2021
Merged

Additional explication for expireInactiveSessions in ParseServerOptions #7552

merged 6 commits into from
Sep 10, 2021

Conversation

lsmilek1
Copy link
Contributor

@lsmilek1 lsmilek1 commented Sep 6, 2021 •
edited
Loading

New Pull Request Checklist

Issue Description

Improve documentation and avoid repeating questions following the discussion on forum

Approach

Extending description line to:

Sets wether we should expire the inactive sessions, defaults to true. If false, all new sessions are created with no expiration date.

TODOs before merging

  • Confirm, that the description was extended on all related places

@lsmilek1
Update docs.js
22a14a3 
Additional explication for `expireInactiveSessions`
@lsmilek1
Update index.js
0469fdf 
Additional explication for `expireInactiveSessions`
@parse-github-assistant
Copy link

parse-github-assistant bot commented Sep 6, 2021 •
edited
Loading

Thanks for opening this pull request!

  • ❌ Please link an issue that describes the reason for this pull request, otherwise your pull request will be closed. Make sure to write it as Related issue: #123 in the PR description, so I can recognize it.

dblythy
dblythy reviewed Sep 7, 2021
View reviewed changes
@mtrezza mtrezza added type:docs Only change in the docs or README and removed type:docs Only change in the docs or README labels Sep 7, 2021
@lsmilek1
Update docs.js
d2825f7 
correcting spelling error
@lsmilek1
Update index.js
eec5e49 
correcting spelling error
@lsmilek1
Update Definitions.js
a8da972
@mtrezza mtrezza merged commit b185fad into parse-community:master Sep 10, 2021
@dblythy
Copy link
Member

dblythy commented Sep 10, 2021

Welcome to the contributors community @lsmilek1 😎

@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.0.0-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Nov 1, 2021
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.0.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtrezza mtrezza mtrezza approved these changes

+1 more reviewer

@dblythy dblythy dblythy approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
state:released Released as stable version state:released-beta Released as beta version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lsmilek1 @dblythy @parseplatformorg @mtrezza