Skip to content

adds scriptlog endpoint #746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 2, 2016
Merged

adds scriptlog endpoint #746

merged 2 commits into from
Mar 2, 2016

Conversation

flovilmart
Copy link
Contributor

No description provided.

@drew-gross
Copy link
Contributor

I think this should replace the /logs endpoint. We don't really want both, and since /logs was experimental/undocumented, we can remove it with breaking compatibility. We can add features to the /scriptlog endpoint compared to Parse.com, we just can't change stuff.

drew-gross
drew-gross reviewed Mar 1, 2016
View reviewed changes
src/Routers/LogsRouter.js
}

handleScriptLog(req) {
const n = req.query.n;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you call this variable size you can construct the options object easier :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah dumb me sometimes

@flovilmart flovilmart force-pushed the flovilmart.logsEndpoint branch from b0e60d3 to 4995260 Compare March 1, 2016 23:44
@facebook-github-bot
Copy link

@flovilmart updated the pull request.

flovilmart
flovilmart reviewed Mar 2, 2016
View reviewed changes
src/Routers/LogsRouter.js
throw new Parse.Error(Parse.Error.PUSH_MISCONFIGURED,
'Logger adapter is not availabe');
}
enforceSecurity(req.auth);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is a middleware for that now on master right?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep. Thanks to @nlutsenko :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

middleware.promiseEnforceMasterKeyAccess ;)

@facebook-github-bot
Copy link

@flovilmart updated the pull request.

@drew-gross
Copy link
Contributor

Feel free to merge with the middleware or do that later

@flovilmart flovilmart force-pushed the flovilmart.logsEndpoint branch from bf7cd09 to 63dc640 Compare March 2, 2016 14:15
@facebook-github-bot
Copy link

@flovilmart updated the pull request.

flovilmart added a commit that referenced this pull request Mar 2, 2016
@flovilmart
Merge pull request #746 from ParsePlatform/flovilmart.logsEndpoint
4e31267 
adds scriptlog endpoint
@flovilmart flovilmart merged commit 4e31267 into master Mar 2, 2016
@flovilmart flovilmart deleted the flovilmart.logsEndpoint branch March 2, 2016 14:38
@snyk-bot snyk-bot mentioned this pull request Aug 25, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@flovilmart @drew-gross @facebook-github-bot @nlutsenko