Removes /logs endpoint

Author: flovilmart

spec/LogsRouter.spec.js

@@ -20,7 +20,7 @@ describe('LogsRouter', () => {
     var router = new LogsRouter();
 
     expect(() => {
-      router.handleGET(request);
+      router.validateRequest(request);
     }).not.toThrow();
     done();
   });
@@ -40,7 +40,7 @@ describe('LogsRouter', () => {
     var router = new LogsRouter();
 
     expect(() => {
-      router.handleGET(request);
+      router.validateRequest(request);
     }).toThrow();
     done();
   });
@@ -60,7 +60,7 @@ describe('LogsRouter', () => {
    var router = new LogsRouter();
 
     expect(() => {
-      router.handleGET(request);
+      router.validateRequest(request);
     }).toThrow();
     done();
   });

src/Routers/LogsRouter.js

@@ -15,12 +15,17 @@ let enforceSecurity = (auth) => {
 export class LogsRouter extends PromiseRouter {
 
   mountRoutes() {
-    this.route('GET','/logs', (req) => {
+    this.route('GET','/scriptlog', this.validateRequest,  (req) => {
       return this.handleGET(req);
     });
-    this.route('GET','/scriptlog', (req) => {
-      return this.handleScriptLog(req);
-    });
+  }
+
+  validateRequest(req) {
+    if (!req.config || !req.config.loggerController) {
+      throw new Parse.Error(Parse.Error.PUSH_MISCONFIGURED,
+        'Logger adapter is not availabe');
+    }
+    enforceSecurity(req.auth);
   }
 
   // Returns a promise for a {response} object.
@@ -30,10 +35,15 @@ export class LogsRouter extends PromiseRouter {
   // until (optional) End time for the search. Defaults to current time.
   // order (optional) Direction of results returned, either “asc” or “desc”. Defaults to “desc”.
   // size (optional) Number of rows returned by search. Defaults to 10
+  // n same as size, overrides size if set
   handleGET(req) {
     const from = req.query.from;
     const until = req.query.until;
-    const size = req.query.size;
+    let size = req.query.size;
+    if (req.query.n) {
+      size = req.query.n;      
+    }
+    
     const order = req.query.order
     const level = req.query.level;
     const options = {
@@ -43,21 +53,6 @@ export class LogsRouter extends PromiseRouter {
       order,
       level,
     }
-    return this.getLogs(req, options);
-  }
-  
-  handleScriptLog(req) {
-    const size = req.query.n;
-    const level = req.query.level;
-    return this.getLogs(req, { size, level });
-  }
-  
-  getLogs(req, options) {
-    if (!req.config || !req.config.loggerController) {
-      throw new Parse.Error(Parse.Error.PUSH_MISCONFIGURED,
-        'Logger adapter is not availabe');
-    }
-    enforceSecurity(req.auth);
     return req.config.loggerController.getLogs(options).then((result) => {
       return Promise.resolve({
         response: result