Skip to content

Conversation

@mtrezza
Copy link
Member

@mtrezza mtrezza commented Apr 5, 2021

New Pull Request Checklist

Issue Description

Parse Server has a dependency on parse-server-simple-mailgun-adapter, which poses several issues. Parse Server uses it just for adapter loading tests.

Related issue: closes #7320

Approach

Replaced dependency on parse-server-simple-mailgun-adapter with new MockMailAdapter sub-package inside Parse Server package.

This is a breaking change, because the adapter has been part of Parse Server and therefore a mail adapter that was available without adding it manually as dependency. For sake of clean-up for the next release, this will be a breaking change without phased deprecation.

TODOs before merging

  • Add test cases
  • Add entry to changelog
  • Add changes to documentation (guides, repository pages, in-code descriptions)

@codecov
Copy link

codecov bot commented Apr 5, 2021

Codecov Report

Merging #7321 (34e2e00) into master (7042552) will decrease coverage by 0.03%.
The diff coverage is n/a.

❗ Current head 34e2e00 differs from pull request most recent head b11cc20. Consider uploading reports for the commit b11cc20 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7321      +/-   ##
==========================================
- Coverage   93.93%   93.89%   -0.04%     
==========================================
  Files         181      181              
  Lines       13194    13194              
==========================================
- Hits        12394    12389       -5     
- Misses        800      805       +5     
Impacted Files Coverage Δ
src/Options/Definitions.js 100.00% <ø> (ø)
src/Options/index.js 100.00% <ø> (ø)
src/Adapters/AdapterLoader.js 95.83% <0.00%> (-4.17%) ⬇️
src/batch.js 91.37% <0.00%> (-1.73%) ⬇️
src/ParseServerRESTController.js 97.01% <0.00%> (-1.50%) ⬇️
...dapters/Storage/Postgres/PostgresStorageAdapter.js 95.36% <0.00%> (-0.16%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7042552...b11cc20. Read the comment docs.

@mtrezza mtrezza requested review from davimacedo and dplewis April 5, 2021 14:48
Copy link
Member

@davimacedo davimacedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@davimacedo davimacedo mentioned this pull request Apr 6, 2021
@mtrezza
Copy link
Member Author

mtrezza commented Apr 6, 2021

Note: The adapter has to be removed from README before merge.

also cleaned up readme and definitions of password / account policy
@mtrezza
Copy link
Member Author

mtrezza commented Apr 6, 2021

Removed simple-mailgun-adapter from README

Also cleaned up the passwordPolicy and accountLockout options in README and improved their docs in Parse Server Options, because they were entangled and poorly documented.

@mtrezza mtrezza merged commit a28433f into parse-community:master Apr 6, 2021
@mtrezza mtrezza deleted the remove-simple-mailgun-adapter branch April 6, 2021 14:32
@dplewis dplewis mentioned this pull request Apr 9, 2021
Arul- pushed a commit to Arul-/parse-server that referenced this pull request Apr 12, 2021
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.0.0-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Nov 1, 2021
@mtrezza mtrezza mentioned this pull request Mar 12, 2022
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.0.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state:released Released as stable version state:released-beta Released as beta version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove simple-mailgun-adapter dependency

3 participants