Skip to content

Conversation

BRETT71
Copy link
Contributor

@BRETT71 BRETT71 commented Mar 2, 2021

New Pull Request Checklist

Issue Description

Add search to the array of PIPELINE_KEYS in AggregateRouter.js. This allows the use of Atlas Search Index Click Here for information on atlas search

Approach

TODOs before merging

  • Add test cases
  • Add entry to changelog
  • Add changes to documentation (guides, repository pages, in-code descriptions)
  • Add security check
  • Add new Parse Error codes to Parse JS SDK
  • ...

@codecov
Copy link

codecov bot commented Mar 2, 2021

Codecov Report

Merging #7237 (c446d42) into master (d789ca6) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7237      +/-   ##
==========================================
- Coverage   94.04%   94.03%   -0.02%     
==========================================
  Files         172      172              
  Lines       12960    12955       -5     
==========================================
- Hits        12188    12182       -6     
- Misses        772      773       +1     
Impacted Files Coverage Δ
src/Routers/AggregateRouter.js 100.00% <ø> (ø)
src/RestWrite.js 93.84% <0.00%> (-0.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d789ca6...b62ab51. Read the comment docs.

@mtrezza
Copy link
Member

mtrezza commented Mar 2, 2021

Thanks for opening this PR.

Would you please

  • open an issue and reference the issue here, as indicated in the PR template
  • add a test case to this PR

@BRETT71
Copy link
Contributor Author

BRETT71 commented Mar 3, 2021

#7238

@BRETT71 BRETT71 mentioned this pull request Mar 3, 2021
3 tasks
@dplewis
Copy link
Member

dplewis commented Mar 3, 2021

@BRETT71 Check the CI there is a test case that has to be removed.

@dplewis
Copy link
Member

dplewis commented Mar 3, 2021

Can you update the change log? And the title of this PR?

@BRETT71 BRETT71 changed the title add search for atlas search index Remove Stage name check on aggregate pipelines Mar 3, 2021
@davimacedo davimacedo merged commit b20aa0c into parse-community:master Mar 3, 2021
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.0.0-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Nov 1, 2021
@mtrezza mtrezza mentioned this pull request Mar 12, 2022
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:released Released as stable version state:released-beta Released as beta version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants