Allow uploading files without Content-Type. #579
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nlutsenko
force-pushed
the
nlutsenko.files.contentType
branch
from
a41bfe3 to
966d10c
Compare
|
@nlutsenko updated the pull request. |
|
LGTM assuming tests pass |
nlutsenko
added a commit
that referenced
this pull request
Feb 22, 2016
Allow uploading files without Content-Type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like our SDKs might be uploading files without
Content-Typeheader, which is valid, since we want the server to automatically pick a content type for us.Remove the restriction by using function instead of a string for body parser type validation (any other ideas on how to remove content-type restriction there are very very welcome).
Also added test that validates that this works now.
Fixes #136