Skip to content

Silences warnings from mongodb client #5025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 4, 2018
Merged

Silences warnings from mongodb client #5025

merged 6 commits into from
Sep 4, 2018

Conversation

flovilmart
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Sep 1, 2018

Codecov Report

Merging #5025 into master will decrease coverage by 0.43%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5025      +/-   ##
==========================================
- Coverage   94.22%   93.79%   -0.44%     
==========================================
  Files         121      122       +1     
  Lines        8820     8857      +37     
==========================================
- Hits         8311     8307       -4     
- Misses        509      550      +41
Impacted Files Coverage Δ
src/ParseServer.js 96.77% <ø> (ø) ⬆️
src/Controllers/index.js 96.55% <100%> (ø) ⬆️
src/Adapters/Storage/Mongo/MongoCollection.js 97.29% <100%> (ø) ⬆️
src/Adapters/Files/GridFSBucketAdapter.js 100% <100%> (ø)
src/Adapters/Storage/Mongo/MongoStorageAdapter.js 92.25% <100%> (+0.01%) ⬆️
src/Routers/FilesRouter.js 58.88% <0%> (-40%) ⬇️
src/Adapters/Files/GridStoreAdapter.js 86.2% <0%> (-13.8%) ⬇️
src/Controllers/FilesController.js 92.3% <0%> (-2.57%) ⬇️
src/RestWrite.js 93.14% <0%> (-0.19%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d83a0b6...bce16c9. Read the comment docs.

@@ -689,7 +689,7 @@ describe('Parse.File testing', () => {
);
});

describe_only_db('mongo')('Gridstore Range tests', () => {
xdescribe('Gridstore Range tests', () => {
Copy link
Contributor Author

@flovilmart flovilmart Sep 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

disabled as GridFSBucket adapter doesn't share the same API as the other one. And total file length isn't available freely. Perhaps could be fixed if really in use

@flovilmart flovilmart merged commit a421015 into master Sep 4, 2018
@flovilmart flovilmart deleted the mongodb-warnings branch September 25, 2018 01:27
UnderratedDev pushed a commit to UnderratedDev/parse-server that referenced this pull request Mar 21, 2020
* Silences warnings from mongodb client

* Update count, delete and finds to recommended implementations

* With new parser, readPref will be null by default

* Update flaky specs wih async/await style

* Adds gridstore adapter spec

* Use GridFSBucketStorage adapter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants