[Cloud Code][Validation] Pass in request object #468
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Cloud Function validation
…g_cf Test for calling non-existing Cloud Function
…st the request parameters
Merged
gfosco
added a commit
that referenced
this pull request
Feb 18, 2016
[Cloud Code][Validation] Pass in request object
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #226 I implemented basic Cloud Function validation logic, the flaw this approach had though is that it only passes in the request parameters which does not contain the user for example.
This PR "fixes" this and passes in the complete request to the validation method.
(I also sneaked in a test for calling a non-existing Cloud Function)