Skip to content

Adds ability to track sent/failed PerUTCOffset in the PushWorker #4158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 13, 2017

Conversation

flovilmart
Copy link
Contributor

  • for scheduled push notifications at a certain time, it helps keep track of the state

- for scheduled push notifications at a certain time, it helps keep track of the state
@flovilmart flovilmart requested a review from acinader September 13, 2017 20:19
acinader
acinader previously approved these changes Sep 13, 2017
Copy link
Contributor

@acinader acinader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

time is hard

lots of test failures....

@codecov
Copy link

codecov bot commented Sep 13, 2017

Codecov Report

Merging #4158 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4158      +/-   ##
==========================================
+ Coverage   92.13%   92.13%   +<.01%     
==========================================
  Files         116      116              
  Lines        8019     8022       +3     
==========================================
+ Hits         7388     7391       +3     
  Misses        631      631
Impacted Files Coverage Δ
src/Controllers/SchemaController.js 97.08% <ø> (ø) ⬆️
src/Push/PushWorker.js 95.08% <100%> (ø) ⬆️
src/StatusHandler.js 99.17% <100%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be2760f...ed39d55. Read the comment docs.

@flovilmart
Copy link
Contributor Author

Yeah I though I could be smart adding the track at 1 place, but it seems that the tests are using sendToAdapter . Just reverted to tracking is A1!

@flovilmart
Copy link
Contributor Author

@acinader, PG was being picky with the schema, it’s all good now!

@flovilmart flovilmart merged commit d598d73 into master Sep 13, 2017
@flovilmart flovilmart deleted the support-push-work-item-offset branch September 13, 2017 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants