Skip to content

Split basic type conversions from other logic in transform.js. #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 4, 2016
Merged

Split basic type conversions from other logic in transform.js. #233

merged 1 commit into from
Feb 4, 2016

Conversation

@nlutsenko
Copy link
Contributor

@nlutsenko nlutsenko commented Feb 4, 2016

Should help with type safety here, as well as can uncover a lot of nasty things.

@nlutsenko
Copy link
Contributor Author

nlutsenko commented Feb 4, 2016

@gfosco I think Date type is incorrectly converted as well, since we sort of enforce conversion for everything, but never convert back, also don't check type when converting the root one.
Will tackle a little bit later.

@nlutsenko nlutsenko force-pushed the nlutsenko.transform.cleaner branch from 32ebc90 to 21aef05 Compare February 4, 2016 06:04
@gfosco gfosco added the accepted label Feb 4, 2016
@gfosco gfosco assigned nlutsenko and unassigned gfosco Feb 4, 2016
nlutsenko added a commit that referenced this pull request Feb 4, 2016
@nlutsenko
Merge pull request #233 from ParsePlatform/nlutsenko.transform.cleaner
72fa1f2 
Split basic type conversions from other logic in transform.js.
@nlutsenko nlutsenko merged commit 72fa1f2 into master Feb 4, 2016
@nlutsenko nlutsenko deleted the nlutsenko.transform.cleaner branch February 4, 2016 08:13
@parseplatformorg parseplatformorg mentioned this pull request Mar 30, 2024
Closed
@pradyum07 pradyum07 mentioned this pull request Mar 30, 2024
Open
@Arul- Arul- mentioned this pull request Mar 30, 2024
Open
@skmezanul skmezanul mentioned this pull request Mar 31, 2024
Open
@kiarza2543 kiarza2543 mentioned this pull request Mar 31, 2024
Open
@parseplatformorg parseplatformorg mentioned this pull request Apr 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@nlutsenko nlutsenko

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nlutsenko @gfosco