containedIn on an array type key

[jeremypiednoel]

Hi Guys !

Issue Description

I'm trying to use containedIn on an array key :

const array = [1 ,2 ,3];
query.containedIn('arrayKey', array);

My key arrayKey is an array in the DB : for instance [1, 3];
My issue is the query will return objects where at least one item from array is in arrayKey and not all of them.
I'm not sure if it's the normal behavior.
If it is do you guys know a workaround ? because containsAll won't work either.
Thanks for the reading.

Steps to reproduce

Make a containedIn query on array key.

Environment Setup

• Server
  • parse-server version : 2.7.4
  • Operating System: macOS 10.12.6 (Sierra)
  • Hardware: iMac (Retina 5K, 27-inch, Late 2015)
  • Localhost or remote server? Localhost

[flovilmart]

This is the expected behavior as containedIn operator in mongodb behaves this way. If you’re looking for and exact match, use the equal operator

[jeremypiednoel]

Thanks @flovilmart i'm not looking for exact match, i'm looking for arrayKey is a subarray of array

[flovilmart]

i believe contains all should do the trick, can you provide the logs when running with VERBOSE=1?

[jeremypiednoel]

I tried with containsAll before asking and it looks like it tries to match all array with arrayKey and not the opposite

here is the verbose

13:56:55 web.1   |  verbose: REQUEST for [GET] /io/classes/Object: {
13:56:55 web.1   |    "where": {
13:56:55 web.1   |      "offers": {
13:56:55 web.1   |        "$all": [
13:56:55 web.1   |          {
13:56:55 web.1   |            "__type": "Pointer",
13:56:55 web.1   |            "className": "Object1",
13:56:55 web.1   |            "objectId": "n2MvEYmqbh"
13:56:55 web.1   |          },
13:56:55 web.1   |          {
13:56:55 web.1   |            "__type": "Pointer",
13:56:55 web.1   |            "className": "Object1",
13:56:55 web.1   |            "objectId": "wR2Ta0KL2R"
13:56:55 web.1   |          }
13:56:55 web.1   |        ]
13:56:55 web.1   |      },
13:56:55 web.1   |      "zipcode": {
13:56:55 web.1   |        "$in": [
13:56:55 web.1   |          "11230",
13:56:55 web.1   |          "11218",
13:56:55 web.1   |        ]
13:56:55 web.1   |      },
13:56:55 web.1   |    },
13:56:55 web.1   |    "limit": 30,
13:56:55 web.1   |    "order": "time"
13:56:55 web.1   |  } method=GET, url=/io/classes/Object, user-agent=node-XMLHttpRequest, Parse/js1.11.1 (NodeJS 9.2.1), accept=*/*, content-type=text/plain, host=localhost:1337, content-length=2521, connection=close, $all=[__type=Pointer, className=Object1, objectId=n2MvEYmqbh, __type=Pointer, className=Object1, objectId=wR2Ta0KL2R], $in=[11230, 11218], limit=30, order=time
13:56:55 web.1   |  verbose: RESPONSE from [GET] /io/classes/Object: {
13:56:55 web.1   |    "response": {
13:56:55 web.1   |      "results": []
13:56:55 web.1   |    }
13:56:55 web.1   |  } results=[]
13:56:55 web.1   |  info: Ran cloud function ------ for user QD8aQ2KCc4 with:
13:56:55 web.1   |    Input: {}
13:56:55 web.1   |    Result: [] functionName=------
13:56:55 web.1   |  verbose: RESPONSE from [POST] /io/functions/------: {
13:56:55 web.1   |    "response": {
13:56:55 web.1   |      "result": []
13:56:55 web.1   |    }
13:56:55 web.1   |  } result=[]

[flovilmart]

You’re matching the zip code or the offers?

[jeremypiednoel]

offers is my array of Object1 in my DB and i try to match it with another array

[jeremypiednoel]

I tried

• containedIn which match at least one item from offers in my array
• containsAll which try to match all items from my array in offers

but none are matching all my offers in array

[flovilmart]

I added a test that should reproduce your issue but it doesn't seem to fail:

#4764

Can you have a look and check whether this is what you were looking for?

[jeremypiednoel]

thanks for the test @flovilmart to recreate the case you should request an All with more objects.

so that would be

"requests": [
    {
      "method": "POST",
      "body": {
        "objects": [
          {
            "__type": "Pointer",
            "className": "Object",
            "objectId": "1OtAIeUHLR"
          },
          {
            "__type": "Pointer",
            "className": "Object",
            "objectId": "spsHOyOE5w"
          }
        ]
      },
      "path": "/1/classes/Parent"
    },
    {
      "method": "POST",
      "body": {
        "objects": [
          {
            "__type": "Pointer",
            "className": "Object",
            "objectId": "z16G0O6abX"
          }
        ]
      },
      "path": "/1/classes/Parent"
    },
    {
      "method": "POST",
      "body": {
        "objects": []
      },
      "path": "/1/classes/Parent"
    }
  ]

with query

"where": {
    "objects": {
      "$in": [
        {
          "__type": "Pointer",
          "className": "Object",
          "objectId": "1OtAIeUHLR"
        },
        {
          "__type": "Pointer",
          "className": "Object",
          "objectId": "z16G0O6abX"
        },
        {
        "__type": "Pointer",
        "className": "Object",
        "objectId": "spsHOyOE5w"
        }
      ]
    }
  }

and the output should be object 1 : azbzJDOlYE and object 3 BIEVwKoBj4 because they are both a subarray of the query

[flovilmart]

I added an additional test, and both matches as you would expect. Closing now as I can't reproduce the issue with the provided information.

Feel free to open a PR with the failing tests.

[jeremypiednoel]

Thanks @flovilmart

here is the case to reproduce

const objects = [1,2,3,4,5,6,7,8].map((idx) => {
  const obj = new Parse.Object('Object');
  obj.set('key', idx);
  return obj;
});
let parent;
let parent3;

Parse.Object.saveAll(objects).then(() => {
  parent = new Parse.Object('Parent');
  parent.set('objects', objects.slice(0, 3));
  
  const parent2 = new Parse.Object('Parent');
  parent2.set('objects', [objects[1]]);
  
  parent3 = new Parse.Object('Parent');
  parent3.set('objects', objects.slice(1, 4));
  
  return Parse.Object.saveAll([parent, parent2, parent3]);
}).then(() => {
  const query = new Parse.Query('Parent');
  query.containedIn('objects', objects);
  return query.find();
}).then((result) => {
  expect(result[0].id).not.toBeUndefined();
  expect(result[1].id).not.toBeUndefined();
  expect(result[2].id).not.toBeUndefined();
  expect(result.length).toBe(3);
}).then(done).catch(done.fail);