Update README.md #18
Merged
Update README.md #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added note about silent-notifications.
Current coverage is 88.12%
@@ master #18 diff @@
========================================
Files 5 5
Lines 239 261 +22
Methods 0 28 +28
Branches 38 45 +7
========================================
+ Hits 208 230 +22
- Misses 30 31 +1
+ Partials 1 0 -1
|
|
Thanks for helping to maintain the docs! |
|
No problem, you can imagine our relief when we finally figured out what the problem was. Should I update the wiki in the main project's push notification section as well or do you think the note here is enough? |
|
It'd be great if you can add the info on the wiki as well. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added note about silent-notifications.