Skip to content

fix: remove tooltip for read-only date field #2323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 7 commits into from
Closed

fix: remove tooltip for read-only date field #2323

wants to merge 7 commits into from

Conversation

sadakchap
Copy link
Member

@sadakchap sadakchap commented Oct 15, 2022 •
edited by mtrezza
Loading

New Pull Request Checklist

Issue Description

Related issue: #1772
Closes: #1772

Approach

Removed tooltip for readonly fields
Update styles for Editor to show disabled state

Disabled Editor styles
image

Disabled Editor selected text
image

TODOs before merging

  • Add tests
  • Add changes to documentation (guides, repository pages, in-code descriptions)
  • A changelog entry is created automatically using the pull request title (do not manually add a changelog entry)

@parse-github-assistant
Copy link

I will reformat the title to use the proper commit message syntax.

@parse-github-assistant parse-github-assistant bot changed the title fix: Remove tooltip for read-only date field fix: remove tooltip for read-only date field Oct 15, 2022
@parse-github-assistant
Copy link

parse-github-assistant bot commented Oct 15, 2022 •
edited
Loading

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@sadakchap sadakchap requested a review from a team October 15, 2022 03:05
mtrezza
mtrezza approved these changes Oct 15, 2022
View reviewed changes
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mtrezza mtrezza closed this Oct 15, 2022
@mtrezza mtrezza deleted the removeTooltip branch October 15, 2022 14:58
@mtrezza mtrezza restored the removeTooltip branch October 15, 2022 14:58
@mtrezza
Copy link
Member

mtrezza commented Oct 15, 2022

Cannot re-open PR, so duplicating this PR in #2326

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtrezza mtrezza mtrezza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove tooltip for read-only date field
2 participants
@sadakchap @mtrezza