Skip to content

refactor: update webpack-cli to latest version #1909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 1, 2021
Merged

refactor: update webpack-cli to latest version #1909

merged 2 commits into from
Nov 1, 2021

Conversation

damianstasik
Copy link
Contributor

New Pull Request Checklist

Issue Description

This PR updates webpack-cli to the latest version. Since 4.1.0 there were many great changes like:

  • fix for the deprecation warning:
(node:21861) [DEP_WEBPACK_WATCH_WITHOUT_CALLBACK] DeprecationWarning: A 'callback' argument needs to be provided to the 'webpack(options, callback)' function when the 'watch' option is set. There is no way to handle the 'watch' option without a callback.
(Use `node --trace-deprecation ...` to show where the warning was created)
  • colored output:
Screen Shot 2021-10-31 at 13 20 22 Screen Shot 2021-10-31 at 13 21 16
  • new option --node-env to set NODE_ENV with webpack-cli, no need to use cross-env
  • fixed watch mode

I tested build command and development mode, everything works as expected.

Related issue: #1902

Approach

TODOs before merging

  • A changelog entry is created automatically using the pull request title (do not manually add a changelog entry)

@parse-github-assistant
Copy link

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@damianstasik damianstasik mentioned this pull request Oct 31, 2021
Closed
56 tasks
@mtrezza
Copy link
Member

mtrezza commented Oct 31, 2021

@visualfanatic Could you please resolve the conflicts?

mtrezza
mtrezza approved these changes Nov 1, 2021
View reviewed changes
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Another deprecation warning less!

@mtrezza mtrezza merged commit 3765771 into parse-community:alpha Nov 1, 2021
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 3.3.0-alpha.15

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Nov 2, 2021
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 4.0.0-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Jan 1, 2022
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 4.0.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtrezza mtrezza mtrezza approved these changes

Assignees
No one assigned
Labels
state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@damianstasik @mtrezza @parseplatformorg @visualfanatic