Skip to content

fix: enabling context menu for read-only cells #1844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 8, 2021
Merged

fix: enabling context menu for read-only cells #1844

merged 7 commits into from
Oct 8, 2021

Conversation

404-html
Copy link
Member

@404-html 404-html commented Oct 7, 2021 •
edited
Loading

New Pull Request Checklist

Issue Description

In #1688 cell context menu (my baby 😭) was disabled for read-only cells (eg. createdAt).

Approach

As such data can still be used for filtering this fix is about re-enabling context menu for read-only cells but without "Edit row" option. I've also pushed small performance optimization and improvement to showing long values in context menu.

TODOs before merging

  • A changelog entry is created automatically using the pull request title (do not manually add a changelog entry)

@parse-github-assistant
Copy link

parse-github-assistant bot commented Oct 7, 2021 •
edited
Loading

Thanks for opening this pull request!

  • ❌ Please check all required checkboxes at the top, otherwise your pull request will be closed.

  • ⚠️ Remember that a security vulnerability must only be reported confidentially, see our Security Policy. If you are not sure whether the issue is a security vulnerability, the safest way is to treat it as such and submit it confidentially to us for evaluation.

@404-html
Copy link
Member Author

404-html commented Oct 7, 2021

Ready to be reviewed ✅

@mtrezza
Copy link
Member

mtrezza commented Oct 7, 2021

Great, I see you are still doing some minor corrections, please feel free to request a review in the "Reviewers" section in the top right corner when this is ready.

@404-html
Copy link
Member Author

404-html commented Oct 7, 2021

Thanks @mtrezza. Sorry, but like last time I'm struggling to find this option, that's all I can do:
image

I wonder if this have something to do with my account. Due to my account name I faced some problems in the past (eg. my profile was throwing 404 page).

@mtrezza
Copy link
Member

mtrezza commented Oct 8, 2021 •
edited
Loading

The option is disabled because you need to be a team member to request a review. Sorry, I thought you already were. Do you want to join the team as a contributor?

@404-html
Copy link
Member Author

404-html commented Oct 8, 2021

Sure, happy to join. People appears to be kind in this team 👍
Will do my best to participate.

@mtrezza
Copy link
Member

mtrezza commented Oct 8, 2021

Amazing, I have opened a poll to confirm you.

mtrezza
mtrezza approved these changes Oct 8, 2021
View reviewed changes
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for the fix!

@mtrezza mtrezza merged commit a38a885 into parse-community:alpha Oct 8, 2021
parseplatformorg pushed a commit that referenced this pull request Oct 8, 2021
@semantic-release-bot
chore(release): 3.2.1-alpha.1 [skip ci]
ea1cae2 
## [3.2.1-alpha.1](3.2.0...3.2.1-alpha.1) (2021-10-08)

### Bug Fixes

* enabling context menu for read-only cells ([#1844](#1844)) ([a38a885](a38a885))
@parseplatformorg
Copy link
Contributor

🎉 This pull request has been released in version 3.2.1-alpha.1

@parse-github-assistant
Copy link

The label state:released on @alpha cannot be used here.

mtrezza added a commit to mtrezza/parse-dashboard that referenced this pull request Oct 8, 2021
@mtrezza
Merge branch 'alpha' into merge-alpha
3761778 
* alpha:
  chore(release): 3.2.1-alpha.1 [skip ci]
  fix: enabling context menu for read-only cells (parse-community#1844)
  docs: add info about --dev parameter (parse-community#1842)
  docs: fix release changelog filename
  docs: reword changelog quote
  docs: fix changelog branch names (parse-community#1837)
  refactor: simplify reading dashboard config from a json file (parse-community#1828)
parseplatformorg pushed a commit that referenced this pull request Oct 8, 2021
@semantic-release-bot
chore(release): 3.2.1-beta.1 [skip ci]
6be4909 
## [3.2.1-beta.1](3.2.0...3.2.1-beta.1) (2021-10-08)

### Bug Fixes

* enabling context menu for read-only cells ([#1844](#1844)) ([a38a885](a38a885))
@parseplatformorg
Copy link
Contributor

🎉 This pull request has been released in version 3.2.1-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Oct 8, 2021
@mtrezza mtrezza added the state:released-alpha Released as alpha version label Oct 8, 2021
parseplatformorg pushed a commit that referenced this pull request Oct 8, 2021
@semantic-release-bot
chore(release): 3.2.1 [skip ci]
ba59eaa 
## [3.2.1](3.2.0...3.2.1) (2021-10-08)

### Bug Fixes

* enabling context menu for read-only cells ([#1844](#1844)) ([a38a885](a38a885))
@parseplatformorg
Copy link
Contributor

🎉 This pull request has been released in version 3.2.1

@parseplatformorg parseplatformorg added the state:released Released as stable version label Oct 8, 2021
beiguancyc pushed a commit to beiguancyc/parse-dashboard that referenced this pull request Oct 9, 2021
@cycqitianwushuge
Merge branch 'source'
5c09465 
* source: (53 commits)
  chore(release): 3.2.1 [skip ci]
  chore(release): 3.2.1-beta.1 [skip ci]
  ci: fix prerelease labels
  chore(release): 3.2.1-alpha.1 [skip ci]
  fix: enabling context menu for read-only cells (parse-community#1844)
  docs: add info about --dev parameter (parse-community#1842)
  build: merge beta (parse-community#1841)
  build: merge alpha (parse-community#1840)
  docs: fix release changelog filename
  docs: reword changelog quote
  docs: fix changelog branch names (parse-community#1837)
  refactor: simplify reading dashboard config from a json file (parse-community#1828)
  ci: update release branch names
  chore(release): 3.2.0 [skip ci]
  feat: add ctrl + arrow key to jump to first/last cell; fix left/right key navigation with hidden columns (parse-community#1827)
  refactor: upgrade inquirer from 8.1.2 to 8.1.3 (parse-community#1829)
  refactor: upgrade otpauth from 7.0.5 to 7.0.6 (parse-community#1830)
  refactor: replace create-react-class with ES6 classes (parse-community#1818)
  refactor: replace query-string with URLSearchParams (parse-community#1819)
  docs: fix typo in refactor changelog entry
  ...

# Conflicts:
#	package-lock.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtrezza mtrezza mtrezza approved these changes

Assignees
No one assigned
Labels
state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@404-html @mtrezza @parseplatformorg