Rename interface to OkHttp3SocketClientFactory.java. #28
Conversation
| import java.net.URI; | ||
| import java.util.Locale; | ||
|
|
||
| /* package */ class TubeSockWebSocketClient implements WebSocketClient { |
There was a problem hiding this comment.
Can also remove the gradle dependency then?
There was a problem hiding this comment.
yeah somehow it was stashed but wasn't committed, repushed
rogerhu
force-pushed
the
okhttp3-1
branch
2 times, most recently
from
f2fe211 to
b56d6ae
Compare
| return new OkHttp3WebSocketClient(mClient, webSocketClientCallback, hostUrl); | ||
| } | ||
|
|
||
| class OkHttp3WebSocketClient implements WebSocketClient { |
There was a problem hiding this comment.
Any reason you didn't keep the Socket implementation into its own file?
There was a problem hiding this comment.
TubeSocketClient has it reversed (the factory is inside TubeSocketClient). That works for static classes, but this class requires an instance to OkHttp3 so Java complains. I reversed it because it's actually the factory class we need access to...the constructors in OkHttp3WebSocketCient/TubeSocketClient are private methods and I don't think the user needs access to that stuff in general so keeping it in the same file avoids having to expose those constructors publicly.
| this.webSocketClientCallback.stateChanged(); | ||
| } | ||
|
|
||
|
|
| } | ||
|
|
||
| /* package */ ParseLiveQueryClientImpl(URI uri, OkHttpClient okHttpClient) { | ||
| this(uri, new OkHttp3SocketClientFactory(okHttpClient), Task.BACKGROUND_EXECUTOR); |
There was a problem hiding this comment.
Maybe we could just accept factory instead of a specific OkHttpClient, so we keep the constructors more generic (interface). Just by passing a WebSocketClientFactory instance (new OkHttp3SocketClientFactory(new OkHttpClient()))
There was a problem hiding this comment.
Good idea. Changed.
I kept the default implementation (line 36) as the default.
…QueryClient to accept OkHttpClient instances.
rogerhu
force-pushed
the
okhttp3-1
branch
2 times, most recently
from
54ab88b to
1fc1ba7
Compare
| import okhttp3.WebSocketListener; | ||
| import okio.ByteString; | ||
|
|
||
| /* package */ |
There was a problem hiding this comment.
mmm I think you forgot that one? :)
| @@ -21,10 +20,18 @@ public static ParseLiveQueryClient getClient() { | |||
| return new ParseLiveQueryClientImpl(); | |||
| } | |||
|
|
|||
| public static ParseLiveQueryClient getClient(WebSocketClientFactory webSocketClientFactory) { | |||
There was a problem hiding this comment.
added a few more interface methods (so you don't need to specify the Uri thanks to changes to @hermanliang
|
still good |
|
Thanks! |
Modify ParseLiveQueryClient to accept OkHttpClient instances.
@mmimeault