Skip to content

feat: improve logging of decoding errors #388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 17, 2022
Merged

feat: improve logging of decoding errors #388

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fb1f31a
Update URLSession.swift
dblythy Aug 11, 2022
be4c5af
Merge branch 'main' into optimize-errors
dblythy Aug 15, 2022
0180231
Merge branch 'main' into optimize-errors
cbaker6 Aug 17, 2022
60728ba
Update .codecov.yml
cbaker6 Aug 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .codecov.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ coverage:
status:
patch:
default:
target: 79
target: 33
changes: false
project:
default:
Expand Down
6 changes: 3 additions & 3 deletions Sources/ParseSwift/Extensions/URLSession.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,11 +88,11 @@ internal extension URLSession {
}
return .failure(ParseError(code: .unknownError,
// swiftlint:disable:next line_length
message: "Error decoding parse-server response: \(response) with error: \(error.localizedDescription) Format: \(String(describing: String(data: responseData, encoding: .utf8)))"))
message: "Error decoding parse-server response: \(response) with error: \(String(describing: error)) Format: \(String(describing: String(data: responseData, encoding: .utf8)))"))
}
return .failure(ParseError(code: .unknownError,
// swiftlint:disable:next line_length
message: "Error decoding parse-server response: \(response) with error: \(error.localizedDescription) Format: \(String(describing: String(data: json, encoding: .utf8)))"))
message: "Error decoding parse-server response: \(response) with error: \(String(describing: error)) Format: \(String(describing: String(data: json, encoding: .utf8)))"))
}
return .failure(parseError)
}
Expand Down Expand Up @@ -130,7 +130,7 @@ internal extension URLSession {
guard let parseError = error as? ParseError else {
return .failure(ParseError(code: .unknownError,
// swiftlint:disable:next line_length
message: "Error decoding parse-server response: \(response) with error: \(error.localizedDescription)"))
message: "Error decoding parse-server response: \(response) with error: \(String(describing: error))"))
}
return .failure(parseError)
}
Expand Down