ParseInstallation does not store object ID in key-value store

[jt9897253]

Assume a struct MyParseInstallation conforming to ParseInstallation.

If I understand the code correctly, calling MyParseInstallation.current?.save { (result: Result<AppInstallInfo, ParseError>) in [...] } intends to persist the ParseInstallation data to the server.

However, calling MyParseInstallation.current?.fetch(completion: { (result: Result<AppInstallInfo, ParseError>) in [...]} always returns a failure.

Problem seems to be that objectId of MyParseInstallation is not persisted to the ParseKeyValueStore. Thus, the fetch returns ParseError(code: ParseSwift.ParseError.Code.unknownError, message: "Cannot fetch an object without id")

Another effect of not storing objectId in the key-value store is that multiple calls to MyParseInstallation.current?.save result in multiple ParseInstallation objects being created on the server, all with the same data but different ids.

Tested on both the latest release and the removeDispatch branch.

[cbaker6]

I'm assuming you are using ParseSwift on Linux/Android? This is very possible, currently looking into the problem...

[jt9897253]

I'm assuming you are using ParseSwift on Linux/Android?

No, tested on iOS and macCatalyst this time. I'll check if #116 addresses the issue

[cbaker6]

I'm assuming you are using ParseSwift on Linux/Android?

No, tested on iOS and macCatalyst this time. I'll check if #116 addresses the issue

Makes sense. When I found what the issue was it showed up across all OSs.

[funkenstrahlen]

I also see this issue. Happy to see a fix is already in the works.

[cbaker6]

I also see this issue. Happy to see a fix is already in the works.

Sure, as soon as one of you confirms it works I will merge

[jt9897253]

I'm not sure if the behavior improved. Tested the following (branch "current"): save the Installation on app start
Behavior is:

• On first app start, the installation is stored on the server correctly
• On subsequent app starts, getting the The data couldn’t be read because it is missing. from Parse Installation #93

[cbaker6]

I'm not sure if the behavior improved. Tested the following (branch "current"): save the Installation on app start
Behavior is:

• On first app start, the installation is stored on the server correctly
• On subsequent app starts, getting the The data couldn’t be read because it is missing. from Parse Installation #93

@jt9897253 Can you post your actual error and your whole Installation struct. Also, can you post what you are calling when you receive this error?

[jt9897253]

Install struct:

private struct AppInstallInfo: ParseInstallation {
    // required for `ParseObject`
    var objectId: String?
    var createdAt: Date?
    var updatedAt: Date?
    var ACL: ParseACL?
    
    // required for `ParseInstallation`
    var installationId: String?
    var deviceType: String?
    var deviceToken: String?
    var badge: Int?
    var timeZone: String?
    var channels: [String]?
    var appName: String?
    var appIdentifier: String?
    var appVersion: String?
    var parseVersion: String?
    var localeIdentifier: String?
    // custom keys can be added here
}

This should be enough to reproduce the issue (parse server running locally in Docker):

if let serverURL = URL(string: "http://localhost:1337/parse") {
    ParseSwift.initialize(applicationId: "APPLICATION_ID", clientKey: "CLIENT_KEY", serverURL: serverURL, keyValueStore: myStore)
    
    AppInstallInfo.current?.save { (result: Result<AppInstallInfo, ParseError>) in
        switch result {
        case .success(let updatedAppInstallInfo):
            callback("successfully saved installation on server: \(updatedAppInstallInfo)")
        case .failure(let error):
            callback("failed to save installation on server: \(error)")
        }
    }
} else {
    callback("invalid parse server url")
}

Full error:

failed to save installation on server: ParseError(code: ParseSwift.ParseError.Code.unknownError, message: "Error decoding parse-server response: Optional(<NSHTTPURLResponse: 0x600002f606c0> { URL: http://localhost:1337/parse/installations } { Status Code: 200, Headers {\n    \"Access-Control-Allow-Headers\" =     (\n        \"X-Parse-Master-Key, X-Parse-REST-API-Key, X-Parse-Javascript-Key, X-Parse-Application-Id, X-Parse-Client-Version, X-Parse-Session-Token, X-Requested-With, X-Parse-Revocable-Session, X-Parse-Request-Id, Content-Type, Pragma, Cache-Control\"\n    );\n    \"Access-Control-Allow-Methods\" =     (\n        \"GET,PUT,POST,DELETE,OPTIONS\"\n    );\n    \"Access-Control-Allow-Origin\" =     (\n        \"*\"\n    );\n    \"Access-Control-Expose-Headers\" =     (\n        \"X-Parse-Job-Status-Id, X-Parse-Push-Status-Id\"\n    );\n    Connection =     (\n        \"keep-alive\"\n    );\n    \"Content-Length\" =     (\n        40\n    );\n    \"Content-Type\" =     (\n        \"application/json; charset=utf-8\"\n    );\n    Date =     (\n        \"Sat, 03 Apr 2021 16:24:52 GMT\"\n    );\n    Etag =     (\n        \"W/\\\"28-73f5/AChhbjMHdlSNQFN7RU2U30\\\"\"\n    );\n    \"Keep-Alive\" =     (\n        \"timeout=5\"\n    );\n    \"X-Powered-By\" =     (\n        Express\n    );\n} }) with error: The data couldn’t be read because it is missing. Format: Optional(\"{\\\"updatedAt\\\":\\\"2021-04-03T16:24:52.550Z\\\"}\")")

[cbaker6]

Are you still using the same device you were using when it wasn't working? If so, can you try logging out so a new installation is generated

If you want to keep your current installation, you can create a query to find your current installation on the server based on the installationId, then save the objectId to your current installation and then save back to the server.

Or, you can delete your installation in Parse Dashboard and run your app again

I've added an auto migration/deletion that will ask for a new installation if the objectId for the current installation isn't saved to the Keychain, so you shouldn't need to do anything else but update the SDK.

[jt9897253]

This was tested on iOS simulator. I just deleted the app, everything from _Installation on the server and the issue is still present on second start.

If you want to keep your current installation, you can create a query to find your current installation on the server based on the installationId

I think I tried that, but was not allowed (got an error message like "you are not allow to query _Installation").

[cbaker6]

I think I see the issue, I'll let you know when I have an update

[jt9897253]

If you want to keep your current installation, you can create a query to find your current installation on the server based on the installationId

Also, as said above, I tried fetching the current installation with

AppInstallInfo.current?.fetch(completion: { (result: Result<AppInstallInfo, ParseError>) in [...]}

but this did not work, presumably as the installation's object id is nil when fetching.

[cbaker6]

I just made a commit that should fix the issue