Issue 916: Deadlock when saving objects with circular references. L… #931
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ited the scope of the lock fixes the issue.
ghost
added
the
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
flovilmart
reviewed
Apr 7, 2017
| message:@"User associated with ACL must be signed up."]; | ||
| } | ||
| return NO; | ||
| dictionaryRepresentationCopy = _estimatedData.dictionaryRepresentation; // This copies the dictionary representation |
There was a problem hiding this comment.
this actually doesn't copy anything, just assigns the pointer, unless you call [_estimatedData.dictionaryRepresentation copy] on it.
|
Could you expand on the fix, and probably add a unit test that would deadlock with the current code? |
|
I don't think I'll have time to work on this anytime soon unfortunately.
On Thu, Apr 6, 2017 at 10:27 PM Florent Vilmart ***@***.***> wrote:
Could you expand on the fix, and probably add a unit test that would
deadlock with the current code?
It seems that removing the lock will have unexpected side effects.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#931 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAvsRBpzQZ5S8gFbWstAiAibsPr6Hm4ks5rtZ8jgaJpZM4IqikK>
.
--
Regards,
Chris
|
|
@czgarrett can you please provide a code that reproduces the issue please? I could very well provide a fix in the upcoming days. In the meantime, I'll close the issue. |
flovilmart
added a commit
that referenced
this pull request
Jan 21, 2018
- As per discussion over there, @nlutsenko and @richardjrossiii were A1 on the resolution Thanks @czgarrett for the fix Closes #931
flovilmart
added a commit
that referenced
this pull request
Jan 30, 2018
- As per discussion over there, @nlutsenko and @richardjrossiii were A1 on the resolution Thanks @czgarrett for the fix Closes #931
flovilmart
added a commit
that referenced
this pull request
Jan 30, 2018
* wip * wip * Initial refactoring of Consistency Assertion to Consistency errors - Make Tried to get invalid local id a soft error - Make Tried to save an object with a new, unsaved child. a soft error - Make Tried to save an object with a pointer to a new, unsaved object. a soft error - Make Attempted to find non-existent uuid a soft error * Soft errors for User consistency checks `_checkSaveParametersWithCurrentUser` * Bumps to latest Swift * Proper failable methods for the LocalIdStore * Adds precondition for checking if user is not merging on itself * Swallow consistency error when decoding * Base error checking on return parameters as unsafe to check error / *error * Restore behaviour for nil tranformed objects without errors * proper ARC modifier for NSError** * Transform assertions to errors in children collection * Adds PFPrecondition instead of Exception when saving cycles * Properly bail on encoding errors, add tests * nits: TODOs * Improve handling of failures for localId resolutiosn * Report missing localId as soft errors * Refactor: Rename macros in PFPreconditon, more consistency on arguments * Better error propagation in resolving localIds * More tests for failures of localId resolutions * Bump version to 1.16.1-alpha.1 * Bump podspec to 1.17.0-alpha.1 * Fix issue #916 - As per discussion over there, @nlutsenko and @richardjrossiii were A1 on the resolution Thanks @czgarrett for the fix Closes #931 * Fixes #1184 - Prevent deadlock by copying estimatedData before traversal * Adds r/w accessors in swift for the PFACL fixes #1083 * Adds CHANGELOG.md * Bumps to 1.17.0-alpha.2 * Fixes flaky test * Provide more context when asserting OfflineStore objectId assignment issues * Bolts doesnt infer failed tasks with NSError as a return type, always return failed tasks if needed * Bump to 1.17.0-alpha.3 * Releases on travis * run pod trunk push with verbose to not stall travis * Review nits * Do no track dimensions if they are nil * Bump version to 1.17.0-alpha.4 * Adds precondition to prevent crash * Fixes errors * Bumps to 1.17.0-alpha.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…imited the scope of the lock fixes the issue.
The only relevant change for the fix is the change in PFObject.m. The PList changes were generated by XCode when I built the project.