Add and use block-based API for querying SQLite database. #603
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nlutsenko
force-pushed
the
nlutsenko.lds.query
branch
from
fd5d37f to
993bca5
Compare
|
@nlutsenko updated the pull request. |
nlutsenko
force-pushed
the
nlutsenko.lds.query
branch
from
337f091 to
abf9ac9
Compare
|
@nlutsenko updated the pull request. |
There was a problem hiding this comment.
If block throws during execution, we end up with statements not being properly closed. If we ever turn on query caching, we get into a really bad state here.
richardjrossiii
added
GH Review: needs-revision
and removed
GH Review: review-needed
labels
nlutsenko
force-pushed
the
nlutsenko.lds.query
branch
from
abf9ac9 to
05890ef
Compare
|
@nlutsenko updated the pull request. |
facebook-github-bot
added
GH Review: review-needed
and removed
GH Review: needs-revision
labels
nlutsenko
added a commit
that referenced
this pull request
Nov 30, 2015
Add and use block-based API for querying SQLite database.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doesn't really add any performance improvements just yet, but this is a waay better API that will guarantee us thread-safety, since the only access to SQLite should be in these blocks.