Skip to content

Fix crash on trying to getData/save a PFFile without local data. #561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 14, 2015
Merged

Fix crash on trying to getData/save a PFFile without local data. #561

merged 1 commit into from
Nov 14, 2015

Conversation

nlutsenko
Copy link
Contributor

  • Report an error when trying to download a file that doesn't have a URL
  • Report an error when trying to upload a file without locally available content (aka no stagedFilePath)
  • Properly return NO for the unsaved files without local content in PFFile.dataAvailable property

Fixes #528.

@nlutsenko nlutsenko force-pushed the nlutsenko.files.unsaved branch from d67edb9 to d8b2adb Compare November 14, 2015 02:41
@nlutsenko nlutsenko added this to the 1.10.0 milestone Nov 14, 2015
nlutsenko added a commit that referenced this pull request Nov 14, 2015
@nlutsenko
Merge pull request #561 from ParsePlatform/nlutsenko.files.unsaved
7994312 
Fix crash on trying to getData/save a PFFile without local data.
@nlutsenko nlutsenko merged commit 7994312 into master Nov 14, 2015
@nlutsenko nlutsenko deleted the nlutsenko.files.unsaved branch November 14, 2015 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nlutsenko nlutsenko

Labels
None yet
Projects
None yet
Milestone
1.10.0
Development

Successfully merging this pull request may close these issues.
3 participants
@nlutsenko @richardjrossiii @facebook-github-bot