Remove potential deadlock from encoding PFUser. #439
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| [queue enumerateObjectsUsingBlock:^(PFOperationSet *operationSet, NSUInteger idx, BOOL *stop) { | ||
| // Remove operations for `password` field, to not let it persist to LDS. | ||
| if (operationSet[PFUserPasswordRESTKey]) { | ||
| operationSet = [operationSet copy]; |
There was a problem hiding this comment.
Because we have an operation set copy, we shouldn't need to copy it again here, nor do we need to check if the key exists first.
There was a problem hiding this comment.
I feel like it's an implementation detail of the superclass method, so probably safer to leave it here.
nlutsenko
force-pushed
the
nlutsenko.user.l
branch
from
3589908 to
e953013
Compare
nlutsenko
force-pushed
the
nlutsenko.user.l
branch
from
e953013 to
0827f5a
Compare
nlutsenko
added a commit
that referenced
this pull request
Oct 20, 2015
Remove potential deadlock from encoding PFUser.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No need for user.lock here, since we removed the super class one as well and we are guaranteed to be passed in a copy of opSetQueue.
Has a potential to resolve yet another deadlock specifically when using users.