Fix all new warnings. #405
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nlutsenko
force-pushed
the
nlutsenko.warnings
branch
from
010cc7c to
3a0c94d
Compare
| } | ||
| } comparisonBlock:^NSPredicate *(NSComparisonPredicate *comparison) { | ||
| NSPredicateOperatorType newType; | ||
| NSComparisonPredicateModifier newModifier = comparison.comparisonPredicateModifier; | ||
| SEL customSelector; | ||
| SEL customSelector = nil; |
There was a problem hiding this comment.
This needs to be NULL, not nil. SEL is not an object type.
nlutsenko
force-pushed
the
nlutsenko.warnings
branch
from
3a0c94d to
e05ea27
Compare
| @@ -86,17 +86,11 @@ + (NSPredicate *)_negatePredicate:(NSPredicate *)predicate { | |||
| } | |||
| return [NSCompoundPredicate andPredicateWithSubpredicates:newSubpredicates]; | |||
| } | |||
| default: { | |||
There was a problem hiding this comment.
I still like having default use cases here. It protects us from some stupid person coming along with a custom predicate and destroying anything. I know it's less optimal, but silent failures are bad.
nlutsenko
force-pushed
the
nlutsenko.warnings
branch
from
e05ea27 to
972be7e
Compare
nlutsenko
force-pushed
the
nlutsenko.warnings
branch
from
972be7e to
96a8e0b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split into multiple commits, but will squash together after review.
Depends on #403