-
-
Notifications
You must be signed in to change notification settings - Fork 876
Rename PFObject '_state' instance variable to '_pfinternal_state'. #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename PFObject '_state' instance variable to '_pfinternal_state'. #35
Conversation
This works, but I am slightly skeptical on usage of double-underscores, since it's reserved by Apple. @richardjrossiii Can we have a test for this, pretty please? |
Will write test, and change from double underscore. Stay tuned... |
d965032
to
b2ee1d2
Compare
Still using double underscores for |
We already reserve fields in parse starting with Will go with your lead and use |
2274b9b
to
64c8241
Compare
LGTM, ship at will after nit is fixed. |
**This is only a temporary workaround**. We should go back and clean up, not only our uses of the '_pfinternal_state' ivar directly, but also discuss whether our auto property synthesis still makes sense to have as a feature. This prevents conflicts with our automatic property synthesis that is done for registered subclasses.
64c8241
to
3e82083
Compare
…te.name.fix Rename PFObject '_state' instance variable to '_pfinternal_state'.
This is only a temporary workaround. We should go back and clean up, not only our uses of the '_pfinternal_state' ivar directly, but also discuss whether our auto property synthesis still makes sense to have as a feature.
This prevents conflicts with our automatic property synthesis that is done for registered subclasses.