Fixed an issue where LDS wouldn't search the whole subtree for objects not yet fetched. #239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Something around |
richardjrossiii
force-pushed
the
richardross.offlinestore.children.fix
branch
from
fda3213 to
b5fb702
Compare
|
Changed to be fixed in eventually pin, rather than offlinestore. |
|
Fabulous! |
When an eventually pin was persisted to LDS, it would not be re-loaded from disk when saving a new eventually pin. This caused issues with the eventually queue, as we would lose columns on objects who weren't currently loaded in memory. Fixes #131.
richardjrossiii
force-pushed
the
richardross.offlinestore.children.fix
branch
from
b5fb702 to
d4e2f5b
Compare
richardjrossiii
added a commit
that referenced
this pull request
Sep 15, 2015
…hildren.fix Fixed an issue where LDS wouldn't search the whole subtree for objects not yet fetched.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This caused issues when using the eventually queue, as the eventually pin objects were getting discarded immediately after creation, and never re-fetched from the database afterward.
Fixes #131.
cc @grantland Does this same issue exist on android?