fix: Parse.setServer doesn't properly validate URL
#1844
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for opening this pull request!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1844 +/- ##
===========================================
+ Coverage 64.24% 82.70% +18.45%
===========================================
Files 201 282 +81
Lines 23233 30735 +7502
===========================================
+ Hits 14926 25418 +10492
+ Misses 8307 5317 -2990 ☔ View full report in Codecov by Sentry. |
mtrezza
approved these changes
Jan 28, 2025
|
Yes, there are flaky test |
|
@mtrezza Is this good to merge? |
|
Yep! |
mtrezza
changed the title
Parse.setServer doesn't handle url validationParse.setServer doesn't properly validate URL
parseplatformorg
pushed a commit
that referenced
this pull request
Jan 31, 2025
## [5.1.1](5.1.0...5.1.1) (2025-01-31) ### Bug Fixes * `Parse.setServer` doesn't properly validate URL ([#1844](#1844)) ([d7b1c8e](d7b1c8e))
|
🎉 This change has been released in version 5.1.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Pull Request Checklist
Issue Description
ParseClientConfigurationTests.testServerValidation test is broken and was excluded from the test suite.
Closes: #1837
Approach
Improve url validation, we could also remove this check and leave it to the developer
TODOs before merging