Skip to content

fix: CollectDirtyChildren causing app to hang when saving object with many pointers #1589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix: CollectDirtyChildren causing app to hang when saving object with many pointers #1589

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
717081a
fix: extra child traversal in collectDirtyChildren to cause app to ha…
shlusiak Jan 5, 2021
7e087f8
Merge branch 'master' into remove-extra-child-traversal-causing-app-t…
mtrezza Oct 29, 2024
b578116
Merge branch 'master' into remove-extra-child-traversal-causing-app-t…
mtrezza Nov 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Parse/Parse/Source/PFObject.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@ + (BFTask *)_enqueue:(BFTask *(^)(BFTask *toAwait))taskStart forObjects:(NSArray
+ (BOOL)collectDirtyChildren:(id)node
children:(NSMutableSet *)dirtyChildren
files:(NSMutableSet *)dirtyFiles
seen:(NSSet *)seen
seen:(NSMutableSet *)seen
seenNew:(NSSet *)seenNew
currentUser:(PFUser *)currentUser
error:(NSError * __autoreleasing *)error {
Expand Down Expand Up @@ -292,7 +292,7 @@ + (BOOL)collectDirtyChildren:(id)node
if ([seen containsObject:object]) {
return YES;
}
seen = [seen setByAddingObject:object];
[seen addObject:object];

// Recurse into this object's children looking for dirty children.
// We only need to look at the child object's current estimated data,
Expand Down Expand Up @@ -334,7 +334,7 @@ + (BOOL)collectDirtyChildren:(id)child
return [self collectDirtyChildren:child
children:dirtyChildren
files:dirtyFiles
seen:[NSSet set]
seen:[NSMutableSet set]
seenNew:[NSSet set]
currentUser:currentUser
error:error];
Expand Down
Loading