Skip to content

Fix #1162 - PFSubclassing.object() class method unavailable since XCode 9 beta 4 #1164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 28, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions Parse/Internal/Object/PFObjectPrivate.h
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,22 @@

@end

@interface PFObject ()

/**
Constructs an object of the most specific class known to implement `+parseClassName`.

This method takes care to help `PFObject` subclasses be subclassed themselves.
For example, `PFUser.+object` returns a `PFUser` by default but will return an
object of a registered subclass instead if one is known.
A default implementation is provided by `PFObject` which should always be sufficient.

@return Returns the object that is instantiated.
*/
+ (instancetype)object;

@end

@interface PFObject (Private)

/**
Expand Down
12 changes: 0 additions & 12 deletions Parse/PFSubclassing.h
Original file line number Diff line number Diff line change
Expand Up @@ -32,18 +32,6 @@ NS_ASSUME_NONNULL_BEGIN

@optional

/**
Constructs an object of the most specific class known to implement `+parseClassName`.

This method takes care to help `PFObject` subclasses be subclassed themselves.
For example, `PFUser.+object` returns a `PFUser` by default but will return an
object of a registered subclass instead if one is known.
A default implementation is provided by `PFObject` which should always be sufficient.

@return Returns the object that is instantiated.
*/
+ (instancetype)object;

/**
Creates a reference to an existing PFObject for use in creating associations between PFObjects.

Expand Down
1 change: 1 addition & 0 deletions Tests/Unit/ProductTests.m
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@

#import "PFProduct.h"
#import "PFUnitTestCase.h"
#import "PFObjectPrivate.h"

@interface ProductTests : PFUnitTestCase

Expand Down
1 change: 1 addition & 0 deletions Tests/Unit/PurchaseUnitTests.m
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
#import "PFTestSKProduct.h"
#import "PFUnitTestCase.h"
#import "Parse_Private.h"
#import "PFObjectPrivate.h"

@protocol PurchaseControllerDataSource <PFCommandRunnerProvider, PFFileManagerProvider>

Expand Down
1 change: 1 addition & 0 deletions Tests/Unit/UserUnitTests.m
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@

#import "PFUnitTestCase.h"
#import "PFUser.h"
#import "PFObjectPrivate.h"

@interface UserUnitTests : PFUnitTestCase

Expand Down