Skip to content

PFTwitterUtils crash #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
maxbryan opened this issue Aug 20, 2015 · 5 comments
Closed

PFTwitterUtils crash #68

maxbryan opened this issue Aug 20, 2015 · 5 comments

Comments

@maxbryan
Copy link

While testing my app I ran across this crash. It looks like it has to do with the PF_Twitter interface. The link with twitter was successful but right after the dialogue screen went away this crash happened.

Is this a known issue with the PF_Twitter/PFTwitterUtils class? Also, did the PFTwitterUtils get open sourced as well? I'm not finding it here.

Thanks.

pftwittercrash

@nlutsenko
Copy link
Contributor

PFTwitterUtils, as well as PFFacebookUtils are coming very soon.
In the meantime - let me try to investigate what happened here.
Can you share a code sample or failing unit test that this fails again?

@nlutsenko nlutsenko added type:bug Impaired feature or lacking behavior that is likely assumed enhancement and removed needs investigation type:bug Impaired feature or lacking behavior that is likely assumed labels Aug 20, 2015
@nlutsenko
Copy link
Contributor

Hey @maxbryan, I think I just got the repro for this.
Apparently - you are specifying the wrong consumerKey and/or consumerSecret for your twitter authentication. I used a generic sample available in ParseUI Demo app.

Please double check those keys and let me know if it was that or not. (feel free to reopen this issue)
In the meantime - I am going to make it not crash, but rather fail with an error specifying that the authentication failed.

@maxbryan
Copy link
Author

Hey thanks @nlutsenko for your quick reply. I know that I have the right consumerKey and consumerSecret because it has worked many times before and continues to do so. It was just this one time that it crashed. I may have had a bad connection at the time... But I don't know much more of what could have caused it.

Will your fix solve the crash problem if it's not the keys that were wrong? Let me know how else I can help. Thanks again.

        PFTwitterUtils.linkUser(currentUser, block: {
            (linked, error) -> Void in

            if let error = error {

                completion(success: false, error: error, displayErrorAlert: true)

            } else {

                completion(success: linked, error: nil, displayErrorAlert: false)
            }

        })

@nlutsenko
Copy link
Contributor

Yup, the crash is going to be solved in the next version of the SDK and it will simply fail gracefully with an error.

@parse-github-assistant
Copy link

The label type:feature cannot be used in combination with type:improvement.

@parse-github-assistant parse-github-assistant bot removed the type:feature New feature or improvement of existing feature label Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants