Skip to content

Add LiveQuery as module #1714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
3 tasks done
mtrezza opened this issue Feb 24, 2023 · 11 comments · Fixed by #1712
Closed
3 tasks done

Add LiveQuery as module #1714

mtrezza opened this issue Feb 24, 2023 · 11 comments · Fixed by #1712
Labels
type:feature New feature or improvement of existing feature

Comments

@mtrezza
Copy link
Member

mtrezza commented Feb 24, 2023

New Feature / Enhancement Checklist

Current Limitation

The LiveQuery SDK is separate from the main SDK. Since the main SDK has SPM support, LiveQuery can be added as a module.

Feature / Enhancement Description

Add LiveQuery as a module.

@parse-github-assistant
Copy link

Thanks for opening this issue!

  • 🎉 We are excited about your ideas for improvement!

@mtrezza mtrezza added the type:feature New feature or improvement of existing feature label Feb 24, 2023
@mtrezza
Copy link
Member Author

mtrezza commented Jun 8, 2023

@Project-Academy The LiveQuery module has been merged and released as version 2.3.0; could you please try it out and let us know in case you find any issues?

@proj-sashido
Copy link

Did some light testing, looks like things are working - thank you!

@mtrezza
Copy link
Member Author

mtrezza commented Jun 13, 2023

Amazing, thanks for the feedback, @Project-Academy; if you could do some more testing and/or find anything weird, please let us know and open an issue. We'll go ahead an archive the other repository.

cc @dplewis

@mtrezza
Copy link
Member Author

mtrezza commented Jun 13, 2023

@sidan5, @extnous, @bayareahank, @owais-applligent, @ChrisCoder9000, @ULSashido, @ritteraf, @HackShitUp, @432player it would be great if you could also test this LiveQuery module out and let us know any feedback

@joaquin102
Copy link

joaquin102 commented Sep 4, 2023

Hey everyone.

I installed this module from 2.7.0 and right out of the box there is an issue with WebSocketDelegate

I am attaching here the screenshot but the main 2 issues are:

  • It seems the delegate changed on the startscream library.
  • Also they added an extra webSocketEvent called -> peerClosed

These errors can be found on ClientPrivate.swift file of the ParseLiveQuery module.

Screenshot 2023-09-04 at 1 00 28 AM

@mtrezza
Copy link
Member Author

mtrezza commented Sep 4, 2023

Interesting that this wasn't picked up by any LiveQuery test in the CI, if it's such a fundamental issue.

@joaquin102 Do you want to open a PR and test to fix this?
@vazarkevych Could you take a look at this?
@dplewis Wasn't this an issue you've mentioned recently in a chat?

@project-saf
Copy link

I noticed this too - it's a change that was made in Starscream v4.0.6
The workaround in the meantime is to add Starscream as a package to your project, and set to the exact version v4.0.4
https://github.com/daltoniam/Starscream.git

@dplewis
Copy link
Member

dplewis commented Sep 5, 2023

@mtrezza I moved the project but never used in production unfortunately.

@cbaker6 I’m still learning swift can you help out?

@joaquin102
Copy link

Sure @mtrezza I'll give it a try!

I can also confirm that the workaround suggested by @project-saf worked👍. The error is gone.

Also, and my apologies if this is not the right channel to post this question (I can delete it if this is not appropriate here), but I'm trying to implement ParseLiveQuery on my iOS app but I can't make it to work. I've spent days on this but I always get the error cannot decode json into
I feel this is a silly error on my end. Does anyone know about this? I posted a full description on stackoverflow:

https://stackoverflow.com/questions/77046879/unable-to-get-parse-ios-sdk-livequery-to-work-always-get-cannot-decode-json-in

Thank you for your help!

@mtrezza
Copy link
Member Author

mtrezza commented Sep 5, 2023

@joaquin102 Thanks a bunch. Regarding your issue, you could also post in the community forum, just make sure to cross-reference with the SO post, to reduce people's efforts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New feature or improvement of existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants