Add better, more flexible APIs for SDK initialization. #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardjrossiii
force-pushed
the
richardross.initialization.update
branch
from
a53d631 to
36895ba
Compare
richardjrossiii
changed the title
richardjrossiii
force-pushed
the
richardross.initialization.update
branch
from
36895ba to
c39e232
Compare
richardjrossiii
force-pushed
the
richardross.initialization.update
branch
from
c39e232 to
f11d216
Compare
| @@ -71,11 +72,6 @@ internal class ParseCommand : HttpRequest { | |||
| if (!string.IsNullOrEmpty(ParseClient.PlatformHooks.OSVersion)) { | |||
| Headers.Add(new KeyValuePair<string, string>("X-Parse-OS-Version", ParseClient.PlatformHooks.OSVersion)); | |||
| } | |||
| if (!string.IsNullOrEmpty(ParseClient.MasterKey)) { | |||
There was a problem hiding this comment.
this was here for a reason, IIRC for Cloud Code stuff. Have you verified that IntegrationTest still run?
|
Looking good. Would be good if you can add a test (something like " |
This PR hopes to unify some of these initialization settings int o a single 'configuration' class that can be easily used to intialize parse in a much cleaner way, especially as we add even more initialization options. Depends on #77.
richardjrossiii
force-pushed
the
richardross.initialization.update
branch
from
f11d216 to
8f45eb2
Compare
richardjrossiii
added a commit
that referenced
this pull request
Dec 14, 2015
…update Add better, more flexible APIs for SDK initialization.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes public API changes
Proposing a new initialization API, to allow for more flexibility and clarity in the future:
No APIs are being directly deprecated at this time, only additions for the time being.
This PR hopes to unify some of these initialization settings int o a single 'configuration' class that can be easily used to intialize parse in a much cleaner way, especially as we add even more initialization options.
Depends on #77.