Remove hard-coded '/1/' from all API request URIs. #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardjrossiii
force-pushed
the
richardross.command.v1
branch
from
99804b1 to
b63ddfa
Compare
richardjrossiii
added a commit
that referenced
this pull request
Nov 16, 2015
This PR hopes to unify some of these initialization settings int o a single 'configuration' class that can be easily used to intialize parse in a much cleaner way, especially as we add even more initialization options. Depends on #77.
This allows us to more easily do path redirection while performing tests.
Now leverages the existing 'ParseCommand' class instead of constructing improperly typed dictionaries. TODO: Split this into its own class.
richardjrossiii
force-pushed
the
richardross.command.v1
branch
from
b63ddfa to
e4fdf05
Compare
richardjrossiii
added a commit
that referenced
this pull request
Nov 16, 2015
This PR hopes to unify some of these initialization settings int o a single 'configuration' class that can be easily used to intialize parse in a much cleaner way, especially as we add even more initialization options. Depends on #77.
|
Looking good. Make sure integration test runs well. I'll update jenkins to reflect the change. |
|
I ran integrations against this locally (that's how I caught the batch encoding stuff). All passed. |
richardjrossiii
added a commit
that referenced
this pull request
Nov 16, 2015
Remove hard-coded '/1/' from all API request URIs.
richardjrossiii
added a commit
that referenced
this pull request
Nov 16, 2015
This PR hopes to unify some of these initialization settings int o a single 'configuration' class that can be easily used to intialize parse in a much cleaner way, especially as we add even more initialization options. Depends on #77.
richardjrossiii
added a commit
that referenced
this pull request
Dec 9, 2015
This PR hopes to unify some of these initialization settings int o a single 'configuration' class that can be easily used to intialize parse in a much cleaner way, especially as we add even more initialization options. Depends on #77.
richardjrossiii
added a commit
that referenced
this pull request
Dec 14, 2015
This PR hopes to unify some of these initialization settings int o a single 'configuration' class that can be easily used to intialize parse in a much cleaner way, especially as we add even more initialization options. Depends on #77.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to more easily do path redirection while performing tests.
Also: Make batch requests no longer require manual encoding.
Now leverages the existing 'ParseCommand' class instead of constructing improperly typed dictionaries.