Ensure LiveQuery subscribes #878
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #878 +/- ##
=========================================
+ Coverage 92.05% 92.1% +0.05%
=========================================
Files 54 54
Lines 5019 5026 +7
Branches 1126 1126
=========================================
+ Hits 4620 4629 +9
+ Misses 399 397 -2
Continue to review full report at Codecov.
|
davimacedo
reviewed
Jul 31, 2019
Member
davimacedo
left a comment
davimacedo
left a comment
There was a problem hiding this comment.
It looks good to me. I am just adding some questions to think about.
davimacedo
approved these changes
Jul 31, 2019
This was referenced Aug 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Its a known issue that query.subscribe instantly returns a subscription without waiting until it subscribes. This PR fixes that.
This PR will make it easier to write Live Query tests on Parse Server.