Skip to content

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Feb 7, 2025

Pull Request

Issue

When making a server request there are options you can use. Most of them aren't documented properly and some are missing.

Approach

  • Refactor request options
  • Remove Object.prototype.hasOwnProperty in favor of Object.hasOwn
  • Turn eslint no-prototype-builtin on
  • Fix tests with done.fail is not a function

Tasks

  • Add tests
  • Add changes to documentation (guides, repository pages, code comments)

Copy link

parse-github-assistant bot commented Feb 7, 2025

Thanks for opening this pull request!

  • ❌ Please link an issue that describes the reason for this pull request, otherwise your pull request will be closed. Make sure to write it as Closes: #123 in the PR description, so I can recognize it.

Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (abadac9) to head (584d7b4).
Report is 30 commits behind head on alpha.

Additional details and impacted files
@@            Coverage Diff             @@
##             alpha     #2430    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           64        64            
  Lines         6392      6271   -121     
  Branches      1549      1450    -99     
==========================================
- Hits          6392      6271   -121     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dplewis dplewis requested a review from a team February 7, 2025 14:56
@dplewis dplewis requested a review from mtrezza February 8, 2025 20:01
@dplewis
Copy link
Member Author

dplewis commented Feb 11, 2025

@mtrezza This is ready for review

@mtrezza mtrezza changed the title refactor: Request options sent to RESTController refactor: Optimize code for request options sent to RESTController Feb 12, 2025
@mtrezza mtrezza merged commit 3cb4f7c into parse-community:alpha Feb 12, 2025
12 checks passed
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.3.0-alpha.6

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Feb 14, 2025
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 6.0.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Mar 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:released Released as stable version state:released-alpha Released as alpha version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants