test: Do not mock ParseObject and ParseOp for ParseQuery tests #2123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for opening this pull request! |
mstniy
changed the title
mstniy
changed the title
mstniy
changed the title
|
I will reformat the title to use the proper commit message syntax. |
parse-github-assistant
bot
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## alpha #2123 +/- ##
===========================================
+ Coverage 99.98% 100.00% +0.01%
===========================================
Files 61 64 +3
Lines 6185 6275 +90
Branches 1499 1506 +7
===========================================
+ Hits 6184 6275 +91
+ Misses 1 0 -1 ☔ View full report in Codecov by Sentry. |
|
🎉 This change has been released in version 5.1.0-alpha.10 |
|
🎉 This change has been released in version 5.1.0-beta.1 |
|
🎉 This change has been released in version 5.1.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Issue
#2122
Closes: #2122
Approach
ParseQuery tests: Do not mock ParseObject and ParseOp
ParseObject mocks used by the ParseQuery tests on the upstream branch are broken, and the LocalDatastore tests are only passing because the ParseQuery tests before them are unmocking
ParseObject.Tasks
None