Skip to content

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Apr 13, 2024

Pull Request

Issue

https://github.com/parse-community/Parse-SDK-JS/actions/runs/8675139200/job/23788227888?pr=2100

Approach

Remove possible race condition on checking length while queue is processing.

Ran 100 times locally and all tests passed

Remove encodeParseObjectInCloudFunction default true warning

Tasks

  • Add tests
  • Add changes to documentation (guides, repository pages, code comments)

Copy link

parse-github-assistant bot commented Apr 13, 2024

Thanks for opening this pull request!

  • ❌ Please link an issue that describes the reason for this pull request, otherwise your pull request will be closed. Make sure to write it as Closes: #123 in the PR description, so I can recognize it.

Copy link

codecov bot commented Apr 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (72bc9ac) to head (dff2235).
Report is 3 commits behind head on alpha.

Additional details and impacted files
@@             Coverage Diff             @@
##            alpha     #2108      +/-   ##
===========================================
+ Coverage   99.98%   100.00%   +0.01%     
===========================================
  Files          61        61              
  Lines        6185      6185              
  Branches     1499      1499              
===========================================
+ Hits         6184      6185       +1     
+ Misses          1         0       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dplewis dplewis requested a review from a team April 13, 2024 20:21
@mtrezza mtrezza changed the title ci: Fix EventuallyQueue flaky tests test: Fix EventuallyQueue flaky tests Apr 13, 2024
@dplewis dplewis requested a review from mtrezza April 13, 2024 21:12
@mtrezza mtrezza merged commit fe29e6e into parse-community:alpha Apr 13, 2024
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.1.0-alpha.2

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Apr 13, 2024
@dplewis dplewis deleted the flaky-eq-tests branch April 13, 2024 22:14
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.1.0-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label May 16, 2024
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.1.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants