Skip to content

fix: Hard-coding of react-native path does not work for workspace builds #1930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 8, 2023
Merged

fix: Hard-coding of react-native path does not work for workspace builds #1930

merged 2 commits into from
Jun 8, 2023

Conversation

swittk
Copy link
Contributor

@swittk swittk commented Jun 5, 2023 •
edited by mtrezza
Loading

Pull Request

Issue

This hard-coding of ../../../react-native/... prevents the package from working in workspace builds.

Closes: None. But the build fails when you use parse/react-native when using PNPM workspaces.

Approach

Change import path from the legacy, hard-coded require('../../../react-native/...') to require('react-native/...')

Tasks

@swittk
Prevent hard-coding of react-native path in react-native builds
b035e7e 
This hard-coding of `../../../react-native/...` prevents the package from working in workspace builds.

Signed-off-by: swittk <[email protected]>
@parse-github-assistant
Copy link

parse-github-assistant bot commented Jun 5, 2023 •
edited
Loading

Thanks for opening this pull request!

  • ❌ Please link an issue that describes the reason for this pull request, otherwise your pull request will be closed. Make sure to write it as Closes: #123 in the PR description, so I can recognize it.

@swittk swittk changed the title Prevent hard-coding of react-native path in react-native builds Fix : Prevent hard-coding of react-native path in react-native builds Jun 5, 2023
@swittk swittk changed the title Fix : Prevent hard-coding of react-native path in react-native builds Fix: Prevent hard-coding of react-native path in react-native builds Jun 5, 2023
@swittk swittk changed the title Fix: Prevent hard-coding of react-native path in react-native builds fix: Prevent hard-coding of react-native path in react-native builds Jun 5, 2023
@mtrezza mtrezza requested a review from a team June 5, 2023 11:03
dplewis
dplewis approved these changes Jun 8, 2023
View reviewed changes
Copy link
Member

@dplewis dplewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I don't know why relative path is there.

@mtrezza mtrezza changed the title fix: Prevent hard-coding of react-native path in react-native builds fix: Hard-coding of react-native path does not work for workspace builds Jun 8, 2023
@mtrezza mtrezza merged commit 8222f3c into parse-community:alpha Jun 8, 2023
parseplatformorg pushed a commit that referenced this pull request Jun 8, 2023
@semantic-release-bot
chore(release): 4.2.0-alpha.2 [skip ci]
473babf 
# [4.2.0-alpha.2](4.2.0-alpha.1...4.2.0-alpha.2) (2023-06-08)

### Bug Fixes

* Hard-coding of `react-native` path does not work for workspace builds ([#1930](#1930)) ([8222f3c](8222f3c))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 4.2.0-alpha.2

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Jun 8, 2023
@dplewis dplewis mentioned this pull request Aug 29, 2023
Closed
4 tasks
parseplatformorg pushed a commit that referenced this pull request Sep 16, 2023
@semantic-release-bot
chore(release): 4.3.0-beta.1 [skip ci]
b821281 
# [4.3.0-beta.1](4.2.0...4.3.0-beta.1) (2023-09-16)

### Bug Fixes

* `ParseUser.linkWith` doesn't remove anonymous auth data ([#2007](#2007)) ([7e2585c](7e2585c))
* Hard-coding of `react-native` path does not work for workspace builds ([#1930](#1930)) ([8222f3c](8222f3c))

### Features

* Add Bytes type to `Parse.Schema` ([#2001](#2001)) ([343d0d7](343d0d7))
* Add Cloud Code context accessibility to `ParseUser.logIn` ([#2010](#2010)) ([2446007](2446007))
* Add support for custom EventEmitter ([#1999](#1999)) ([ca568a6](ca568a6))
* Add support for excluding keys in `ParseQuery.findAll` ([#2000](#2000)) ([012ba4c](012ba4c))
* Add support to invoke a Cloud Function with a custom `installationId` via `Parse.Cloud.run` ([#1939](#1939)) ([eb70b93](eb70b93))
* Allow overriding `Parse.Error` message with custom message via new Core Manager option `PARSE_ERRORS` ([#2014](#2014)) ([be0c8a6](be0c8a6))
* Login with username, password and additional authentication data via `ParseUser.logInWithAdditionalAuth` ([#1955](#1955)) ([2bad411](2bad411))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 4.3.0-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Sep 16, 2023
parseplatformorg pushed a commit that referenced this pull request Sep 26, 2023
@semantic-release-bot
chore(release): 4.3.0-alpha.1 [skip ci]
e0b713e 
# [4.3.0-alpha.1](4.2.0...4.3.0-alpha.1) (2023-09-26)

### Bug Fixes

* `ParseUser.linkWith` doesn't remove anonymous auth data ([#2007](#2007)) ([7e2585c](7e2585c))
* Hard-coding of `react-native` path does not work for workspace builds ([#1930](#1930)) ([8222f3c](8222f3c))

### Features

* Add Bytes type to `Parse.Schema` ([#2001](#2001)) ([343d0d7](343d0d7))
* Add Cloud Code context accessibility to `ParseUser.logIn` ([#2010](#2010)) ([2446007](2446007))
* Add support for custom EventEmitter ([#1999](#1999)) ([ca568a6](ca568a6))
* Add support for excluding keys in `ParseQuery.findAll` ([#2000](#2000)) ([012ba4c](012ba4c))
* Add support to invoke a Cloud Function with a custom `installationId` via `Parse.Cloud.run` ([#1939](#1939)) ([eb70b93](eb70b93))
* Allow overriding `Parse.Error` message with custom message via new Core Manager option `PARSE_ERRORS` ([#2014](#2014)) ([be0c8a6](be0c8a6))
* Login with username, password and additional authentication data via `ParseUser.logInWithAdditionalAuth` ([#1955](#1955)) ([2bad411](2bad411))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 4.3.0-alpha.1

parseplatformorg pushed a commit that referenced this pull request Nov 16, 2023
@semantic-release-bot
chore(release): 4.3.0 [skip ci]
5194c03 
# [4.3.0](4.2.0...4.3.0) (2023-11-16)

### Bug Fixes

* `ParseUser.linkWith` doesn't remove anonymous auth data ([#2007](#2007)) ([7e2585c](7e2585c))
* Hard-coding of `react-native` path does not work for workspace builds ([#1930](#1930)) ([8222f3c](8222f3c))

### Features

* Add Bytes type to `Parse.Schema` ([#2001](#2001)) ([343d0d7](343d0d7))
* Add Cloud Code context accessibility to `ParseUser.logIn` ([#2010](#2010)) ([2446007](2446007))
* Add support for custom EventEmitter ([#1999](#1999)) ([ca568a6](ca568a6))
* Add support for excluding keys in `ParseQuery.findAll` ([#2000](#2000)) ([012ba4c](012ba4c))
* Add support to invoke a Cloud Function with a custom `installationId` via `Parse.Cloud.run` ([#1939](#1939)) ([eb70b93](eb70b93))
* Allow overriding `Parse.Error` message with custom message via new Core Manager option `PARSE_ERRORS` ([#2014](#2014)) ([be0c8a6](be0c8a6))
* Login with username, password and additional authentication data via `ParseUser.logInWithAdditionalAuth` ([#1955](#1955)) ([2bad411](2bad411))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 4.3.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dplewis dplewis dplewis approved these changes

Assignees
No one assigned
Labels
state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@swittk @parseplatformorg @dplewis @mtrezza