fromJSON: Return date if value is a date #1293
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure how often this error would occur, but if you try to create a
ParseObject
withfromJSON
with a Date, the date field is returned as{}
Related
Evidently, this bug also affects the localDataStore tests as:
descending date order should be larger (newer) to smaller (older)
Obj1: createdAt: new Date('2018-08-10T00:00:00.000Z'),
Obj2: createdAt: new Date('2018-08-11T00:00:00.000Z'),
Obj3: createdAt: new Date('2018-08-12T00:00:00.000Z'),
So, this test:
Should return Obj3, Obj2, Obj1. Instead, it returns Obj1, Obj2, then Obj3.
If this doesn't make sense, if you change the order that the objects are loaded here (e.g to Obj2, Obj3, Obj1), the tests will fail on the current master.