Skip to content

Conversation

@dblythy
Copy link
Member

@dblythy dblythy commented Dec 4, 2020

Copy link
Member

@davimacedo davimacedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.

@dplewis
Copy link
Member

dplewis commented Dec 4, 2020

@dblythy can you merge from master for the CI?

@codecov
Copy link

codecov bot commented Dec 4, 2020

Codecov Report

Merging #1268 (a5d4f7a) into master (17a2f0a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1268   +/-   ##
=======================================
  Coverage   99.98%   99.98%           
=======================================
  Files          57       57           
  Lines        5405     5407    +2     
  Branches     1204     1204           
=======================================
+ Hits         5404     5406    +2     
  Misses          1        1           
Impacted Files Coverage Δ
src/ParseError.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17a2f0a...a5d4f7a. Read the comment docs.

Copy link
Member

@dplewis dplewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davimacedo github actions saved 45 seconds on CI time

@dplewis dplewis merged commit f24bd99 into parse-community:master Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants