Skip to content

Conversation

@dplewis
Copy link
Member

@dplewis dplewis commented Oct 24, 2020

eslint 5.1.0 removed the built in JSDoc validator.

Using eslint-plugin-jsdoc

@ghost
Copy link

ghost commented Oct 24, 2020

Danger run resulted in 1 fail and 1 markdown; to find out more, see the checks page.

Generated by 🚫 dangerJS

@codecov
Copy link

codecov bot commented Oct 24, 2020

Codecov Report

Merging #1240 into master will decrease coverage by 0.00%.
The diff coverage is 92.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1240      +/-   ##
==========================================
- Coverage   92.46%   92.46%   -0.01%     
==========================================
  Files          54       54              
  Lines        5308     5307       -1     
  Branches     1198     1198              
==========================================
- Hits         4908     4907       -1     
  Misses        400      400              
Impacted Files Coverage Δ
src/Analytics.js 100.00% <ø> (ø)
src/Cloud.js 93.33% <ø> (ø)
src/FacebookUtils.js 100.00% <ø> (ø)
src/LiveQueryClient.js 87.76% <ø> (ø)
src/LiveQuerySubscription.js 100.00% <ø> (ø)
src/LocalDatastore.js 99.13% <ø> (ø)
src/LocalDatastoreUtils.js 100.00% <ø> (ø)
src/OfflineQuery.js 99.55% <ø> (ø)
src/ParseACL.js 94.06% <ø> (ø)
src/ParseConfig.js 87.95% <ø> (ø)
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 188074f...87035d8. Read the comment docs.

Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dplewis dplewis merged commit edd25f5 into master Oct 24, 2020
@dplewis dplewis deleted the jsdocs-eslint branch October 24, 2020 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants