-
-
Notifications
You must be signed in to change notification settings - Fork 596
Added support to delete Parse.File #1067
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch! How did we miss this?
Codecov Report
@@ Coverage Diff @@
## master #1067 +/- ##
==========================================
+ Coverage 92.22% 92.23% +<.01%
==========================================
Files 54 54
Lines 5185 5187 +2
Branches 1160 1161 +1
==========================================
+ Hits 4782 4784 +2
Misses 403 403
Continue to review full report at Codecov.
|
@stevestencil @davimacedo @acinader Anything you want to add? |
@dplewis I would recommend adding an options argument to the destroy() function. Reason being everything else that requires the master key forces you to pass in { useMasterKey: true } into the options. Also, I know right now the master key is required to delete files (which limits it to only cloud code), but in the future I would like to add the ability to do it client side with a session token. |
No description provided.