-
-
Notifications
You must be signed in to change notification settings - Fork 214
refactor: Remove deprecated property window from dart:ui in favor of PlatformDispatcher
#878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Remove deprecated property window from dart:ui in favor of PlatformDispatcher
#878
Conversation
Thanks for opening this pull request!
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #878 +/- ##
==========================================
- Coverage 38.69% 38.68% -0.02%
==========================================
Files 56 56
Lines 3277 3278 +1
==========================================
Hits 1268 1268
- Misses 2009 2010 +1
☔ View full report in Codecov by Sentry. |
|
Is this a breaking change or only an internal refactor without any effects for developers? |
|
Internal refactor the developers will not notice it |
PlatformDispatcher rather than the deprecated property window form dart:uiwindow from dart:ui in favor of PlatformDispatcher
|
Alright, so we also don't need a changelog entry for it. All looks green - yay! - can we merge this? |
window from dart:ui in favor of PlatformDispatcherwindow from dart:ui in favor of PlatformDispatcher
|
sure, we can!!!!!!!! finally :) |
|
Is this the last breaking change for the Parse Flutter SDK? If so, we could release Flutter 5.0.0 with this PR.
|
But then if anyone uses Flutter SDK will be locked to Dart SDK 4.x.x.
No, there is nothing like that in the Flutter SDK |
|
Alright, I'll go ahead and merge. |
New Pull Request Checklist
Issue Description
Closes: #877
Approach
Use the PlatformDispatcher class as recommended by the Flutter docs see window class docs
TODOs before merging