-
-
Notifications
You must be signed in to change notification settings - Fork 214
fix: Remove deprecated parameter vsync from AnimatedSize
#864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for opening this pull request!
|
Nidal-Bakir
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add a changelog entry and bump the version?
OK I am trying. Thank you! |
Nidal-Bakir
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You also can remove this line.
with SingleTickerProviderStateMixin
finished! Please check it out, thank you. |
vsync.vsync form AnimatedSize.
Nidal-Bakir
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Looks good.
|
If we remove a property and therefore remove support for currently supported Flutter SDK versions then this is a breaking change. Let's discuss this in the issue. |
I don't think it is a breaking change. Because it is a deprecated variable. Also, this issue and change is inside Parse and does not affect the api |
|
@mbfakourii Could you comment in the issue (see link in my previous comment)? From the discussion there it seems that this is in fact a breaking change. |
I checked, is it true that I think it is a breaking change, with these qualities, we have a lot of breaking change in PRs!? |
|
@mtrezza |
|
No, its not |
|
Sorry, I forgot that there was discussion here already about this. So since removing a deprecated param is breaking, I've added an additional entry in the BREAKING CHANGES section. I think one of the problems we have now is that the CI for Flutter generally fails. So maybe before we merge this PR we can fix the general issue so that the CI runs properly before we merge any more PRs? Edit: the CI works again after resolving the conflicts, so I guess we can merge this. |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #864 +/- ##
=======================================
Coverage 38.69% 38.69%
=======================================
Files 56 56
Lines 3277 3277
=======================================
Hits 1268 1268
Misses 2009 2009
☔ View full report in Codecov by Sentry. |
|
The issue with CI is related to this PR and issue #877. Once we merge/fix them, the CI tests for Flutter should pass. |
vsync form AnimatedSize.vsync from AnimatedSize
|
This is great! Thanks for your work! |
New Pull Request Checklist
Issue Description
Closes: #861
Approach
Remove the specified
vsyncproperty.TODOs before merging