Skip to content

Clean ParseHttpRequset and ParseHttpResposne #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 4, 2015
Merged

Clean ParseHttpRequset and ParseHttpResposne #99

merged 3 commits into from
Sep 4, 2015

Conversation

wangmengyan95
Copy link
Contributor

Clean ParseHttpRequest and ParseHttpResponse and add comment
For Builder

  1. All constructor are public
  2. All fields are private
  3. Add addHeader(), addHeaders() and setHeaders() helper methods
    For ParseHttpRequest and ParseHttpResponse
  4. All constructor are private
  5. All fields are final and private
  6. Add newBuilder() helper method
  7. Header map is unmodifiable

@wangmengyan95 wangmengyan95 force-pushed the wangmengyan.clean_ParseHttpRequset_and_ParseHttpResponse branch from 00ec0ab to 12b7060 Compare September 2, 2015 03:06
@wangmengyan95 wangmengyan95 added this to the 1.10.2 milestone Sep 2, 2015
grantland
grantland reviewed Sep 2, 2015
View reviewed changes
Parse/src/main/java/com/parse/ParseHttpRequest.java
/** package */ class ParseHttpRequest {

/**
* The {@link ParseHttpRequest} method type.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the reference is the class you're in, we generally use {@code blah}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kk

@wangmengyan95 wangmengyan95 force-pushed the wangmengyan.clean_ParseHttpRequset_and_ParseHttpResponse branch from 1044d75 to 224909c Compare September 4, 2015 00:33
wangmengyan95 added a commit that referenced this pull request Sep 4, 2015
@wangmengyan95
Merge pull request #99 from ParsePlatform/wangmengyan.clean_ParseHttp…
70f5c20 
…Requset_and_ParseHttpResponse

Clean ParseHttpRequset and ParseHttpResposne
@wangmengyan95 wangmengyan95 merged commit 70f5c20 into master Sep 4, 2015
@wangmengyan95 wangmengyan95 deleted the wangmengyan.clean_ParseHttpRequset_and_ParseHttpResponse branch September 4, 2015 00:40
@facebook-github-bot
Copy link

@wangmengyan95 updated the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@wangmengyan95 wangmengyan95

Labels
None yet
Projects
None yet
Milestone
1.10.2
Development

Successfully merging this pull request may close these issues.
4 participants
@wangmengyan95 @facebook-github-bot @grantland @hallucinogen