Skip to content

Commit 1044d75

Browse files
committed
Remove newBuilder method for ParseHttpRequest and ParseHttpResponse
1 parent 7c35cbd commit 1044d75

File tree

6 files changed

+4
-20
lines changed

6 files changed

+4
-20
lines changed

Parse/src/main/java/com/parse/ParseDecompressInterceptor.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ public ParseHttpResponse intercept(Chain chain) throws IOException {
3333
// to -1
3434
newHeaders.put(CONTENT_LENGTH_HEADER, "-1");
3535
// TODO(mengyan): Add builder constructor based on an existing ParseHttpResponse
36-
response = response.newBuilder()
36+
response = new ParseHttpResponse.Builder(response)
3737
.setTotalSize(-1)
3838
.setHeaders(newHeaders)
3939
.setContent(new GZIPInputStream(response.getContent()))

Parse/src/main/java/com/parse/ParseHttpRequest.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -135,10 +135,6 @@ private ParseHttpRequest(Builder builder) {
135135
this.body = builder.body;
136136
}
137137

138-
public Builder newBuilder() {
139-
return new Builder(this);
140-
}
141-
142138
public String getUrl() {
143139
return url;
144140
}

Parse/src/main/java/com/parse/ParseHttpResponse.java

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -130,18 +130,6 @@ public ParseHttpResponse build() {
130130
this.contentType = builder.contentType;
131131
}
132132

133-
/**
134-
* Generates a new {@link com.parse.ParseHttpResponse.Builder} based on an
135-
* {@code ParseHttpResponse}, the {@link com.parse.ParseHttpResponse.Builder}'s values are come
136-
* from the {@code ParseHttpResponse}.
137-
*
138-
* @return A new {@link com.parse.ParseHttpResponse.Builder} whose values are come from the
139-
* {@code ParseHttpResponse}.
140-
*/
141-
public Builder newBuilder() {
142-
return new Builder(this);
143-
}
144-
145133
public int getStatusCode() {
146134
return statusCode;
147135
}

Parse/src/main/java/com/parse/ParseLogInterceptor.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -287,7 +287,7 @@ public void done(InputStream proxyInput, IOException e) {
287287
logResponseInfo(getLogger(), requestId, response, IGNORED_BODY_INFO);
288288
}
289289

290-
return response.newBuilder()
290+
return new ParseHttpResponse.Builder(response)
291291
.setContent(newResponseBodyStream)
292292
.build();
293293
}

Parse/src/test/java/com/parse/ParseHttpRequestTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ public void testParseHttpRequestBuildWithParseHttpRequest() throws IOException {
104104
.build();
105105

106106
String newURL = "www.api.parse.com";
107-
ParseHttpRequest newRequest = request.newBuilder()
107+
ParseHttpRequest newRequest = new ParseHttpRequest.Builder(request)
108108
.setUrl(newURL)
109109
.build();
110110

Parse/src/test/java/com/parse/ParseHttpResponseTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ public void testParseHttpResponseBuildWithParseHttpResponse() throws IOException
8888
.build();
8989

9090
String newReasonPhrase = "Failed";
91-
ParseHttpResponse newResponse = response.newBuilder()
91+
ParseHttpResponse newResponse = new ParseHttpResponse.Builder(response)
9292
.setReasonPhrase(newReasonPhrase)
9393
.build();
9494

0 commit comments

Comments
 (0)