Skip to content

Convert project to use AndroidX #926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 14, 2019
Merged

Convert project to use AndroidX #926

merged 1 commit into from
Feb 14, 2019

Conversation

Jawnnypoo
Copy link
Member

This converts the project to SDK 28 and AndroidX, along with updating the OkHttp dependency to the latest version that supports our minSDK.

Next release should likely be a 1.19.0, since the upgrade path might not be compatible if others are not using AndroidX already.

@rogerhu
Copy link
Contributor

rogerhu commented Feb 14, 2019

Lgtm

Copy link
Contributor

@rogerhu rogerhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we bump okhttp too?

@Jawnnypoo
Copy link
Member Author

It's hard to tell, but yep, I did that too 👍

@Jawnnypoo Jawnnypoo merged commit 29c45f4 into master Feb 14, 2019
@Jawnnypoo Jawnnypoo deleted the androidx branch February 14, 2019 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants