Fix signUp and linkWith with an anonymous user #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Still writing a unit test that will simulate this behavior for the future. |
|
So it doesn't seem like there's a good way to write a unit test as the scenario is more of a integration test scenario, especially since I added |
grantland
force-pushed
the
grantland.lazy
branch
from
5d90e09 to
7d71b2e
Compare
|
LGTM |
|
So this is basically the same as our initial behavior, except |
|
@lukas1994 yeah we have integration tests for this. they're currently failing and this makes them pass @hallucinogen pretty much |
|
Sounds good then. |
Fixes integration test failures caused by #52 We strip anonymity in `signUp` and `linkWith` before calling into `saveAsync` where there's a fork in logic for `isLazy()`. Since we now determine `isLazy()` based off `objectId != null && ParseAnonymousUtils.isLinked(this)`, `isLazy()` returns the incorrect value for these logic paths. The solution is to get the value of `isLazy()` before stripping anonymity and passing it through to `saveAsync()`. * Callers of resolveLazinessAsync never use it's return value, might as well make it Void * Make signUp more robust by reverting current user's password on failure if that's how it originally was * Make signUp more robust by reverting the current user's password on success
grantland
force-pushed
the
grantland.lazy
branch
from
7d71b2e to
fc249c0
Compare
grantland
added a commit
that referenced
this pull request
Aug 27, 2015
Fix signUp and linkWith with an anonymous user
|
@grantland updated the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes integration test failures caused by #52
We strip anonymity in
signUpandlinkWithbefore calling intosaveAsyncwhere there's a fork in logic forisLazy(). Since we nowdetermine
isLazy()based offobjectId != null && ParseAnonymousUtils.isLinked(this),isLazy()returns the incorrect value for these logic paths.The solution is to get the value of
isLazy()before stripping anonymityand passing it through to
saveAsync().Void