Remove isLazy property in ParseUser #52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // This will set the unresolvedUser in acl | ||
| acl.setReadAccess(unresolvedUser, true); | ||
| acl.setWriteAccess(unresolvedUser, true); | ||
|
|
||
| unresolvedUser.setObjectId("test"); | ||
| acl.resolveUser(unresolvedUser); | ||
| unresolvedUser.setObjectId("test"); |
There was a problem hiding this comment.
What's the reasoning we need this?
There was a problem hiding this comment.
Sorry, I'll remove this.
|
@lukas1994 just a few questions |
|
LGTM If you could squash and rebase on master, I can merge! |
We always have the invariant:
lazy == true <==> objectId == null && authData.get("anonymous") != null
So we can remove the additional property.
For testing: to get the "lazy" user behavior we need to make sure that the user has no objectId and we need to set "anonymous" authData (see setLazy() in ParseACLTest.java).
grantland
added a commit
that referenced
this pull request
Aug 25, 2015
Remove isLazy property in ParseUser
grantland
added a commit
that referenced
this pull request
Aug 27, 2015
Fixes integration test failures caused by #52 We strip anonymity in `signUp` and `linkWith` before calling into `saveAsync` where there's a fork in logic for `isLazy()`. Since we now determine `isLazy()` based off `objectId != null && ParseAnonymousUtils.isLinked(this)`, `isLazy()` returns the incorrect value for these logic paths. The solution is to get the value of `isLazy()` before stripping anonymity and passing it through to `saveAsync()`.
grantland
added a commit
that referenced
this pull request
Aug 27, 2015
Fixes integration test failures caused by #52 We strip anonymity in `signUp` and `linkWith` before calling into `saveAsync` where there's a fork in logic for `isLazy()`. Since we now determine `isLazy()` based off `objectId != null && ParseAnonymousUtils.isLinked(this)`, `isLazy()` returns the incorrect value for these logic paths. The solution is to get the value of `isLazy()` before stripping anonymity and passing it through to `saveAsync()`.
grantland
added a commit
that referenced
this pull request
Aug 27, 2015
Fixes integration test failures caused by #52 We strip anonymity in `signUp` and `linkWith` before calling into `saveAsync` where there's a fork in logic for `isLazy()`. Since we now determine `isLazy()` based off `objectId != null && ParseAnonymousUtils.isLinked(this)`, `isLazy()` returns the incorrect value for these logic paths. The solution is to get the value of `isLazy()` before stripping anonymity and passing it through to `saveAsync()`. * Callers of resolveLazinessAsync never use it's return value, might as well make it Void * Make signUp more robust by reverting current user's password on failure if that's how it originally was * Make signUp more robust by reverting the current user's password on success
|
@lukas1994 updated the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We always have the invariant:
lazy == true<==>objectId == null && authData.get("anonymous") != nullSo we can remove the additional property.
For testing: to get the "lazy" user behavior we need to make sure that the user has no
objectIdand we need to set "anonymous"authData(seesetLazy()inParseACLTest.java).