Add ParseFileHttpBody and ParseCountingFileHttpBody #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangmengyan95
force-pushed
the
wangmengyan.t8145272_add_ParseFileHttpBody
branch
from
b0dbb87 to
c7554b9
Compare
| @@ -212,7 +212,7 @@ public ParseApacheHttpClient(int socketOperationTimeout, SSLSessionCache sslSess | |||
| private static class ParseApacheHttpEntity extends InputStreamEntity { | |||
| private ParseHttpBody parseBody; | |||
|
|
|||
| public ParseApacheHttpEntity(ParseHttpBody parseBody) { | |||
| public ParseApacheHttpEntity(ParseHttpBody parseBody) throws IOException { | |||
There was a problem hiding this comment.
Any reason for this change?
There was a problem hiding this comment.
Since parseBody.getContent() will try to create a fileStream in some cases, so we need to throw IOException here.
|
LGTM |
wangmengyan95
added a commit
that referenced
this pull request
Aug 28, 2015
…rseFileHttpBody Add ParseFileHttpBody and ParseCountingFileHttpBody
|
@wangmengyan95 updated the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ParseFileHttpBodyand testParseCountingFileHttpBodyand testParseHttpBody.getContent(), right now it should throwIOExceptionParseRequestandParseResponsefrominttolong